upcoming: [UIE-9380] - Service URI PG Bouncer Connection Details Section#13182
Conversation
packages/manager/src/features/Databases/DatabaseDetail/ConnectionDetailsRow.tsx
Outdated
Show resolved
Hide resolved
...ages/manager/src/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseNetworking.tsx
Outdated
Show resolved
Hide resolved
|
This pull request should also be adding the new I wonder if it'd make sense to just have it in the Summary tab with the new section for this pull request and to add it into the |
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx
Outdated
Show resolved
Hide resolved
|
@smans-akamai there is a separate ticket for adding the service URI to the summary tab (UIE-9327) and it looks like there are minor changes compared to the Networking tab
|
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| }; | ||
|
|
||
| const serviceURI = `postgres://${credentials?.username}:${credentials?.password}@${database.hosts?.primary}?sslmode=require`; |
There was a problem hiding this comment.
Is the assumption here that, after copying, they'll know to add the connection pool port and connection pool label before ?sslmode=require in the service URI string?
When they copy this, those will be missing and it looks like we're excluding the placeholders from the copy output for it. This looks like the intention, so I assume this behavior was already agreed upon.
There was a problem hiding this comment.
^ I have this question as well
There was a problem hiding this comment.
Just added ?sslmode=require to the copied string
If the credentials call is successful, the pool port and label will be present in the copied string because we are copying again in https://github.com/hana-akamai/manager/blob/UIE-9380-service-uri-pg-bouncer/packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx#L43
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx
Outdated
Show resolved
Hide resolved
smans-akamai
left a comment
smans-akamai
left a comment
There was a problem hiding this comment.
My previous feedback was addressed! I left a few comments on some smaller changes I'd recommend, but those could be looked at separately as part of the other Service URI ticket, UIE-9380 if we want to get this merged in.
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx
Outdated
Show resolved
Hide resolved
...ages/manager/src/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseNetworking.tsx
Outdated
Show resolved
Hide resolved
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Verification steps ✅
| } | ||
| }; | ||
|
|
||
| const serviceURI = `postgres://${credentials?.username}:${credentials?.password}@${database.hosts?.primary}?sslmode=require`; |
There was a problem hiding this comment.
^ I have this question as well
|
|
||
| interface ServiceURIProps { | ||
| database: Database; | ||
| } |
There was a problem hiding this comment.
Since there will be a general case for the ServiceURI component outside of PgBouncer with UIE-9327, we should consider making this component reusable for both scenarios (Connection Pool URI and General Service URI)
Since we haven't confirmed the general format yet, this could be taken up as part of the next UIE ticket that adds to the Service URI to the Summary tab. But I just wanted to bring that up here for consideration.
Cloud Manager UI test results🎉 867 passing tests on test run #8 ↗︎
|
4 participants
Description 📝
Add reusable Service URI component for PG Bouncer and place it in the Networking -> Connection Pools section
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2025-12-23.at.2.56.01.PM.mov
Screen.Recording.2025-12-23.at.2.58.58.PM.mov
Mobile
How to test 🧪
Prerequisites
(How to setup test environment)
Database PgBouncerflag onVerification steps
(How to verify changes)
click to revealpassword, copying, loading, error & mobile statesAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅