feat: [UIE-9798] - IAM: Enable account_viewer to access roles table#13200
Merged
aaleksee-akamai merged 7 commits intolinode:developfrom Dec 17, 2025
Merged
feat: [UIE-9798] - IAM: Enable account_viewer to access roles table#13200aaleksee-akamai merged 7 commits intolinode:developfrom
aaleksee-akamai merged 7 commits intolinode:developfrom
Conversation
Collaborator
Cloud Manager UI test results🎉 831 passing tests on test run #2 ↗︎
|
mpolotsk-akamai
approved these changes
Dec 16, 2025
abailly-akamai
approved these changes
Dec 17, 2025
| } | ||
|
|
||
| if (!permissions?.is_account_admin) { | ||
| if (!permissions?.view_account) { |
Contributor
There was a problem hiding this comment.
Should we be defensive here and ALSO check for is_account_admin? In light of the recent changes I am wondering if we have to start doing multiple checks like that in case the permission isn't properly returned.
Contributor
Author
There was a problem hiding this comment.
makes sense, I've added !(permissions?.view_account || permissions?.is_account_admin)
aaleksee-akamai
force-pushed
the
UIE-9798
branch
from
d371fe9 to
1fc418e
Compare
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR allows users with
account_viewerrole to see the roles table.Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
account_viewerrole:account_viewerrole:How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
view_accountpermissionAssign Roleis enabled if user has ais_account_adminpermissionAssign Roleis disabled if user does not have ais_account_adminpermissionAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅