Skip to content

fix: [UIE-9853], [UIE-9855] - IAM: fix Roles Table layout shifts, disable email input for users without account_admin#13208

Merged
mpolotsk-akamai merged 3 commits intolinode:developfrom
mpolotsk-akamai:UIE-9853-disable-input
Dec 18, 2025
Merged

fix: [UIE-9853], [UIE-9855] - IAM: fix Roles Table layout shifts, disable email input for users without account_admin#13208
mpolotsk-akamai merged 3 commits intolinode:developfrom
mpolotsk-akamai:UIE-9853-disable-input

Conversation

@mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Dec 16, 2025

Description 📝

This PR fixes Roles Table layout shifts when switching tabs, and disables email input for users without account_admin

Changes 🔄

List any change(s) relevant to the reviewer.

  • disable email input in User Details
  • fix UI in Roles Table

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Before After
Screenshot 2025-12-17 at 10 34 22 AM Screenshot 2025-12-17 at 10 33 51 AM

How to test 🧪

Prerequisites

  • use IAM account (not-admin) with/without account_viewer role

Verification steps

(How to verify changes)

  • navigate to /iam/users/[username]/details
  • verify that email input is disabled for user with only account_viewer role
  • navigate to /iam/users/[username]/roles and switch tab to Entities
  • verify that Table elements do not jump when switching tabs.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

… email input for users without account_admin
…and the email input is enabled for users without the account_admin role
@mpolotsk-akamai mpolotsk-akamai marked this pull request as ready for review December 17, 2025 09:51
@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner December 17, 2025 09:51
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming changes look good (although i had a hard time reproducing the layout shift)

Thanks @mpolotsk-akamai !

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 18, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing828 Passing11 Skipped47m 32s

Details

Failing Tests
SpecTest
vpc-details-page.spec.tsCloud Manager Cypress Tests→VPC details page » can create, edit, and delete a subnet from the VPC details page
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-details-page.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@mpolotsk-akamai mpolotsk-akamai merged commit fdf6af4 into linode:develop Dec 18, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants