refactor: [UIE-9856] - Clean up hardcoded entity name in firewall add event

[grevanak-akamai]

Description 📝

This is continuation of PR-12685. As part of this PR, additional cleanup of hardcoded entity name 'Linode interface' along with cleanup of TODO has been taken care.

Changes 🔄

• Removed TODO and hardcoded entity name for firewall add event message

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

NA

Preview 📷

no visual differences

How to test 🧪

Verification steps

(How to verify changes)

• Upon adding Linode Interface to firewall, confirm Linode Interface firewall device add message makes sense.
• Confirm no regressions impact in this flow.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[linode-gh-bot]

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
1 Failing	829 Passing	11 Skipped	35m 55s

Details

Failing Tests
	Spec	Test
❌	search-images.spec.ts	Cloud Manager Cypress Tests→Search Images » creates two images and make sure they show up in the table and are searchable

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/images/search-images.spec.ts"

[coliu-akamai]

✅ confirmed firewall messages make sense

unrelated to this PR: I noticed that for Linode Interface Linodes, I can't remove the interface firewall device from a firerwall's device page, despite being able to from the Linode's network interface table:

firewall device page - remove device button disabled

Linode's network interface table - edit linode interface drawer -> can still remove device here:

This looks like it might be a permissions issue between IAM and Linode interfaces, potentially because there isn't yet IAM support for Linode Interfaces

Approving this PR because the IAM vs Linode Interface issue is separate, but I think we should create a new ticket in UIE-9806 to keep track of it + reach out to the IAM team as needed. It might also be worth looking into the disabledDueToPermissions logic in FirewallDeviceActionMenu.tsx and related files to see if we can/should update the disabling of the firewall device action menu for Linode Interfaces in the meantime

Thanks @grevanak-akamai!

(also adding @bnussman-akamai as a reviewer since he worked on linode interfaces too)

[grevanak-akamai]

can't remove the interface firewall device from a firerwall's device page, despite being able to from the Linode's network interface table

Thanks @coliu-akamai for pointing out this issue. I have created a separate ticket for this and will fix it.