Skip to content

fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer#13212

Merged
abailly-akamai merged 4 commits intolinode:developfrom
abailly-akamai:UIE-9884
Dec 19, 2025
Merged

fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer#13212
abailly-akamai merged 4 commits intolinode:developfrom
abailly-akamai:UIE-9884

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Dec 18, 2025

Description 📝

In the User Assigned Roles UI, when trying to change role to another (Change Role drawer) but already has entities assigned to a role, those roles are filtered out, resulting in the user potentially being confused. The API allows to PUT to the same role with same or different entities so we should allow it too.

Changes 🔄

  • Remove already assigned roles Role filter in <ChangeRoleDrawer />

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

Prerequisites

An IAM account with admin role

Reproduction steps

Consider assigning entities to similar roles. ex:
Screenshot 2025-12-15 at 12 23 24

  • Navigate to /iam/users//roles
  • Open the "Change Role" drawer for one of the firewalls
  • ⛔ Can't select one of the similar roles

Verification steps

  • Navigate to /iam/users//entities
  • Open the "Change Role" drawer for one of the firewalls
  • ✅ Similar roles are all available
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai self-assigned this Dec 18, 2025
@abailly-akamai abailly-akamai changed the title fix: [UIE-9884] - Remove role filtering in change role drawer (Roles Tab) fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleForEntityDrawer Dec 19, 2025
@abailly-akamai abailly-akamai changed the title fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleForEntityDrawer fix: [UIE-9840] - IAM: Remove Role filter (already assigned roles) in ChangeRoleDrawer Dec 19, 2025
@abailly-akamai abailly-akamai marked this pull request as ready for review December 19, 2025 08:45
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 19, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing866 Passing11 Skipped44m 12s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@abailly-akamai abailly-akamai merged commit 677db9c into linode:develop Dec 19, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants