Skip to content

upcoming: [DI-28773] - Support to select system channel based on service type controlled by LD flag#13219

Merged
venkymano-akamai merged 4 commits intolinode:developfrom
venkymano-akamai:allow_system_channel_by_service
Dec 23, 2025
Merged

upcoming: [DI-28773] - Support to select system channel based on service type controlled by LD flag#13219
venkymano-akamai merged 4 commits intolinode:developfrom
venkymano-akamai:allow_system_channel_by_service

Conversation

@venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Dec 22, 2025

Description 📝

Allow to select system notification channel while creating / editing alert based on the service type selected controlled through LD flag

Changes 🔄

  1. New LD flag under aclpAlerting - systemChannelSupportedServices which holds the service type for which to support adding system notification channels
  2. Reset channel ids if service type is changed.
  3. Disable Add Notification Channel button if service type is not selected
  4. In AddChannelListing use the LD to show whether to allow selecting system channel or not.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️ (Next release)

25-12-2025 inside linode develop branch

Preview 📷

Before After
Screenshot 2025-12-20 at 9 11 24 PM Screenshot 2025-12-22 at 1 02 31 PM
Screenshot 2025-12-22 at 1 03 11 PM image

How to test 🧪

  1. Login as mock
  2. Navigate to Monitor and then to Alerts
  3. Click on create alert
  4. You should see Add Notification Channel disabled when service type is not selected
  5. Once you select the service type, inside the drawer you see channels grouped by System and User
  6. If LD supports only linode, to achieve this in line number of 68 of AddChannelListing you can use the following
    flags.aclpAlerting?.systemChannelSupportedServices ?? ['linode'];
  7. Now for the rest of services , you will not be able to see system channels
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 867 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing867 Passing11 Skipped50m 48s

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 22, 2025
@venkymano-akamai venkymano-akamai merged commit 930bc9f into linode:develop Dec 23, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants