Skip to content

Added: [DI-28776] - Use customized humanize method for cloudpulse metrics#13224

Merged
venkymano-akamai merged 6 commits intolinode:developfrom
venkymano-akamai:humanize_bug_fix
Dec 24, 2025
Merged

Added: [DI-28776] - Use customized humanize method for cloudpulse metrics#13224
venkymano-akamai merged 6 commits intolinode:developfrom
venkymano-akamai:humanize_bug_fix

Conversation

@venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Dec 23, 2025

Description 📝

The current humanizeLargeData method in area chart, doesn't round off the values less than 1000, but in CloudPulse we need round of that to 1 decimal points

Changes 🔄

  1. New humanizeLargeData method, in cloudpulse utils.
  2. Use that method in legends, tooltip and yAxis of CloudPulse metrics graph

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Rounded to 2places Rounded to 1 Place
Screenshot 2025-12-23 at 7 38 58 PM Screenshot 2025-12-23 at 7 38 43 PM

How to test 🧪

  1. Login into Monitor and Navigate to metrics
  2. In the dashboards, select a firewall dashboard
  3. Choose required filters and in the widgets, scroll to the bottom
  4. In the Count related widgets, there will be trimmed Y-axis
  5. For the humanization to work, do the following change in CloudPulseLineGraph line 35

const isHumanizableUnit =
(flags.aclp?.humanizableUnits ?? ['Count'])?.some(
(unitElement) => unitElement.toLowerCase() === unit.toLowerCase()
) ?? false;

  1. In CloudPulseWidget humanizableUnits: flags.aclp?.humanizableUnits ?? ['Count'], in line 449
  2. Now for the same you will see humanized values, small values are rounded off to 1 decimal places, you can see this in average

Prerequisites

  • Have access for firewalls and linodes
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 23, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 869 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing869 Passing11 Skipped47m 58s

@venkymano-akamai venkymano-akamai merged commit 63863f1 into linode:develop Dec 24, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants