upcoming: [DI-29080] - Notification Channel Types#13227
Merged
ankita-akamai merged 3 commits intolinode:developfrom Jan 1, 2026
Merged
upcoming: [DI-29080] - Notification Channel Types#13227ankita-akamai merged 3 commits intolinode:developfrom
ankita-akamai merged 3 commits intolinode:developfrom
Conversation
venkymano-akamai
approved these changes
Dec 29, 2025
ankita-akamai
approved these changes
Dec 31, 2025
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
||||||||||||||||||||
Contributor
|
Merging as there are enough approvals and failures are unrelated!! |
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Notification Channel Type changes to accomodate the latest API specification and to support backward compatibility
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
NO UI Change
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
{ "pages": 1, "page": 1, "results": 4, "data": [ { "id": 10000, "label": "Read-Write Channel", "channel_type": "email", "type": "system", "content": { "email": { "email_addresses": [ "Users-with-read-write-access-to-resources" ] } }, "details": { "email": { "usernames": [], "recipient_type": "read_write_users" } }, "alerts": { "url": "/monitor/alert-channels/10000/alerts", "type": "alerts-definitions", "alert_count": 11 }, "created": "2025-09-04T07:48:14", "updated": "2025-12-18T05:39:00", "created_by": "system", "updated_by": "system" }, { "id": 10003, "label": "My User Email Channel", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10003/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-21T21:05:05", "updated": "2025-12-21T21:05:05", "created_by": "vagrant", "updated_by": "system" }, { "id": 10004, "label": "new custom alert", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10004/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-22T19:46:21", "updated": "2025-12-22T19:46:21", "created_by": "vagrant", "updated_by": "system" }, { "id": 10005, "label": "new custom alert 2", "channel_type": "email", "type": "user", "content": {}, "details": { "email": { "usernames": [ "vagrant" ], "recipient_type": "user" } }, "alerts": { "url": "/monitor/alert-channels/10005/alerts", "type": "alerts-definitions", "alert_count": 0 }, "created": "2025-12-22T19:49:26", "updated": "2025-12-22T19:49:26", "created_by": "vagrant", "updated_by": "system" } ] }Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅