logging: add nvme_mi_submit entry and exit functions #2807
Conversation
|
LGTM. |
jk-ozlabs
left a comment
jk-ozlabs
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments inline.
| .cdw15 = le32_to_cpu(hdr->cdw15), | ||
| }; | ||
|
|
||
| nvme_show_common(&cmd); |
There was a problem hiding this comment.
I think we would want include the dofst / dlen here too, otherwise the data may not make much sense.
There was a problem hiding this comment.
Just added the doff and dlen mentioned and also fix to use le32_to_cpu() for the cdw0 result output.
| const void *data, size_t data_len) | ||
| { | ||
| printf("result : %08x\n", hdr->cdw0); | ||
| printf("err : %d\n", hdr->status); |
There was a problem hiding this comment.
I assume we don't want the data here?
There was a problem hiding this comment.
Currently nvme_submit_passthru() for PCIe does not print the data so at this moment not required as same but later possible to be added the data output also I think.
Only supported for the NVMe-MI message type NVMe admin command. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
logging-nvme-mi
branch
from
c33e4aa to
900adf5
Compare
jk-ozlabs
left a comment
jk-ozlabs
left a comment
There was a problem hiding this comment.
I'm not fully across the logging patterns in general, but +1 from me on the MI-related parts.
|
FWIW, I think it's safe to modify the logging later on. I don't consider this as a stable interface in any sorts. Let's start with this and see what works and what needs some more changes later on. |
|
Thanks! |
3 participants
Only supported for the NVMe-MI message type NVMe admin command.