File and output stream line ending compatibility changes

[brgoing]

Makes Windows output behavior match other platforms by using O_BINARY to prevent text-mode line ending translation (LF to CRLF) that can corrupt binary output.

• Introduces O_NVME_WRONLY, which includes O_BINARY when O_BINARY is defined, and updates file-open calls to use it.
• Configures stdout and stderr to use O_BINARY on Windows

[igaw]

I don't like this approach with overloading of the flags flags. The resulting code doesn't read well.

What about introducing something like nvme_open_binary/nvme_open_rawfile/nvme_open_datafile (or any better name) which handles this internally.

[brgoing]

I don't like this approach with overloading of the flags flags. The resulting code doesn't read well.

What about introducing something like nvme_open_binary/nvme_open_rawfile/nvme_open_datafile (or any better name) which handles this internally.

Okay. Thank you for the feedback. We discussed multiple approaches to this, including defining O_BINARY as 0 on Linux and including it in the flags used, introducing a new nvme_open method like you mentioned, or the modified O_WRONLY approach we went with in this PR. Each had its own drawbacks, so we figured we needed to pick one and go with it to start the conversation.