Merged
Conversation
Contributor
dealako
commented
Jul 1, 2019
dealako
commented
- Added reference to the public user's guide
- Added maintainers list
* Added maintainers list
fayazg
approved these changes
Jul 1, 2019
5 tasks
This was referenced Jul 10, 2020
dealako
added a commit
that referenced
this pull request
Jul 10, 2020
Updated event logging based on the above referenced ticket, hightlights include: - Regarding #1 - CLAMangerDelted event looks to be configured correctly via [this bit of code](https://github.com/communitybridge/easycla/blob/master/cla-backend-go/cla_manager/service.go#L352) - Add GitHub username to the approval list is configured to log the even per [this bit of code](https://github.com/communitybridge/easycla/blob/master/cla-backend-go/signatures/service.go#L663). All the events relating to the approval list should be generated from this function. Type is: `cla_manager.approval_list_updated` - Updated event code for ICLA and CCLA signature signing - Resolved #2 added additional details/parameters - Resolved #3 item above, parameters were not provided to event logger - Resolved #4 updated text - Resolved #5: ICLA is individual, CCLA is slang for both Corporate CLA signed by CLA Manager and Employee Signature. But, in this case you are mentioning it is the CLA document signed by the signatory. I have updated the event logging logic to account for logging all events. Signed-off-by: David Deal <dealako@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.