fix: expose contributor id to prevent identity split #1512
Conversation
Signed-off-by: Ankitkr-ak007 <[email protected]>
Ankitkr-ak007
force-pushed
the
fix/contributor-identity-split
branch
from
f376533 to
0a700b5
Compare
|
Hey @Ankitkr-ak007 thanks for your interest in contributing. |
|
Hey, |
I have add my gpg key now can you please merge it |
|
@Ankitkr-ak007 please fix the conflicts first, we'll merge after. Thanks. |
Can You help me with this as I'm not able to understand and fix the conflict. Please help me out. |
…nkitkr-ak007/insights into fix/contributor-identity-split
Ankitkr-ak007
force-pushed
the
fix/contributor-identity-split
branch
2 times, most recently
from
af16b82 to
e0b2dc9
Compare
Signed-off-by: Ankitkr-ak007 <[email protected]>
Ankitkr-ak007
force-pushed
the
fix/contributor-identity-split
branch
from
e0b2dc9 to
2fc2c82
Compare
|
Please Check these changes as i think it should be done. |
|
Hey, before merging can you just fix lint errors. |
Signed-off-by: Ankit Kumar <[email protected]>
Ankitkr-ak007
force-pushed
the
fix/contributor-identity-split
branch
from
7239243 to
2a31123
Compare
|
Lint, format and typescript check still failing |
|
Let me do it again |
Signed-off-by: Efren Lim <[email protected]> Signed-off-by: Ankit Kumar <[email protected]>
Signed-off-by: Gašper Grom <[email protected]> Signed-off-by: Ankit Kumar <[email protected]>
Signed-off-by: Ankit Kumar <[email protected]>
Ankitkr-ak007
force-pushed
the
fix/contributor-identity-split
branch
from
063a967 to
ec62ba9
Compare
|
@gaspergrom I have again made some changes. Thank for your continuous Support Sir. |
Signed-off-by: Ankit Kumar <[email protected]>
|
Commits must have verified signatures. |
gaspergrom
left a comment
gaspergrom
left a comment
There was a problem hiding this comment.
Reviewing this PR - posting individual comments
| expect(result).toEqual(expectedResult); | ||
| }); | ||
|
|
||
| test('should aggregate contributors with the same display name', async () => { |
| data: dataResponse.data.map( | ||
| (item): Contributor => ({ | ||
| // Aggregate data by displayName | ||
| const aggregatedData = new Map<string, Contributor>(); |
There was a problem hiding this comment.
Revert code in this file
4 participants
Description
Exposed the unique
idfield in the contributors data source and mapped it to the frontend interface.Motivation (Fixes)
This resolves the issue where a single contributor was being split into multiple entries on the leaderboard. By using the unique
idfrom the backend, we ensure stable identity tracking regardless of name or email variations.