Skip to content

drop2beets implementation #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bvanroll wants to merge 2 commits into
base: master
Choose a base branch
from
Open

drop2beets implementation #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b84e6a5
drop2beets implementation
bvanroll Aug 11, 2025
51dfc41
forgot the aarch64 version :p
bvanroll Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ RUN \
requests \
requests_oauthlib \
typing-extensions \
unidecode && \
unidecode \
drop2beets && \
printf "Linuxserver.io version: ${VERSION}\nBuild-date: ${BUILD_DATE}" > /build_version && \
echo "**** cleanup ****" && \
apk del --purge \
Expand All @@ -103,6 +104,8 @@ ENV BEETSDIR="/config" \
EDITOR="nano" \
HOME="/config"

RUN mkdir /downloads #it freaked out without this :(

# copy local files
COPY root/ /

Expand Down
5 changes: 4 additions & 1 deletion Dockerfile.aarch64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ RUN \
requests \
requests_oauthlib \
typing-extensions \
unidecode && \
unidecode \
drop2beets && \
printf "Linuxserver.io version: ${VERSION}\nBuild-date: ${BUILD_DATE}" > /build_version && \
echo "**** cleanup ****" && \
apk del --purge \
Expand All @@ -104,6 +105,8 @@ ENV BEETSDIR="/config" \
EDITOR="nano" \
HOME="/config"

RUN mkdir /downloads #it doesn't start without this :/

# copy local files
COPY root/ /

Expand Down
8 changes: 5 additions & 3 deletions root/defaults/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
plugins: fetchart embedart convert scrub replaygain lastgenre chroma web
plugins: fetchart embedart convert scrub replaygain lastgenre chroma web drop2beets
drop2beets:
dropbox_path: /downloads
directory: /music
library: /config/musiclibrary.blb
art_filename: albumart
Expand All @@ -21,8 +23,8 @@ paths:

import:
write: yes
copy: yes
move: no
copy: no
move: yes
resume: ask
incremental: yes
quiet_fallback: skip
Expand Down
5 changes: 5 additions & 0 deletions root/etc/s6-overlay/s6-rc.d/svc-beets/run
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/usr/bin/with-contenv bash
# shellcheck shell=bash

if [[ -v DROP_ENABLED ]]; then
Copy link

@dtrunk90 dtrunk90 Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if an ENV var is better than parsing beet config to see if the plugin is enabled, like I did in ebffeef#diff-3cda36eef1a7876daa6d7d37a13f13b35786f37d0c9db349583eac408013f5ac

echo "dropbox is enabled"
Copy link

@dtrunk90 dtrunk90 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the echo statement, drop2beets is already logging properly. There's no need for that.

beet dropbox &
Copy link

@dtrunk90 dtrunk90 Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this line to:

if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
    exec \
        s6-setuidgid abc beet dropbox &
else
    exec \
        beet dropbox &
fi

Or move it to its own s6 overlay and get rid of the & at the end of the command.

fi

if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost 8337" \
Expand Down