Amplify Output button increases vertical size

[madlep]

The existing "Amplify output" button increases horizontal size, but when returning a large data structure and/or sending a larger amount of data to stdout, the small vertical size is frustrating. Especially so on larger screen where there is more real estate to work with.

• increase vertical size too when "Amplify output" is clicked.
• regular size unchanged at 300px
• "Amplified" size at 600px

This preserves existing logic by keeping the amplify setting client side only, and not relying on state managed via the liveview process. It could be done that way, but kept it consistent with current implementation.

amplify_output_vertically.mov

[CLAassistant]

All committers have signed the CLA.

[josevalim]

This looks good to me but I wonder if we should go with a bit more conservative change, such as 450? Or maybe we should make the height configurable altogether, I don't know.

[madlep]

This looks good to me but I wonder if we should go with a bit more conservative change, such as 450? Or maybe we should make the height configurable altogether, I don't know.

@josevalim 450px still feels a bit small. At least when generating more output on a larger monitor where you want to optionally be able to use the screen real estate more effectively.

A few ideas:

• "Amplify output" button becomes modal, rather than a toggle. ie, have 3 or more modes that alternate each time you click. Could start default narrow/short -> wide/short -> wide/tall -> back to narrow/short. Alternatively could have a number of stateful "radio" buttons for size rather than one that cycles through modes.
• A cell setting UI option for "number of lines in output" or similar ("lines" is more user friendly than px size)
• Some special annotations embedded in comments at the top of a code/markdown input cell controlling output height
• Jupyter notebooks has a "Disable scrolling for outputs" right click menu option which maximises the height to match the actual output. I don't love this, as it is either too short by default, or really too tall for large output when disabled.

What are your thoughts?

[mogorman]

i would love for it to be configurable or if i could click in the anchor and expand to the length i need it to. 300px on my machine is only 13 lines which is not optimal for me at least