Open
Conversation
🦋 Changeset detectedLatest commit: 756c6c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
This is a duplicate of #1394 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
u9g
commented
May 6, 2026
u9g
commented
May 6, 2026
| this.span?.setAttribute(traceTypes.ATTR_AMD_CATEGORY, result.category); | ||
| this.span?.setAttribute(traceTypes.ATTR_AMD_REASON, result.reason); | ||
| this.span?.setAttribute(traceTypes.ATTR_AMD_IS_MACHINE, result.isMachine); | ||
| this.span?.setAttribute(traceTypes.ATTR_AMD_SPEECH_DURATION, result.speechDurationMs); |
Contributor
Author
There was a problem hiding this comment.
why are there so many wider reaching changes that weren't part of the original diff?
Contributor
Author
There was a problem hiding this comment.
this was more like a port of other AMD behavior in a trench coat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speechDurationMsanddelayMsresult fields, using an explicit zero delay when no speech end timestamp exists.Tests
pnpm test -- agents/src/voice/amd.test.tspnpm test -- agents/src/telemetry/traces.test.tspnpm --filter @livekit/agents buildpnpm lint(passes with existing warnings in unrelated files)Notes
pnpm --filter @livekit/agents api:checkfails before API comparison on existing API Extractor unsupportedexport * as ...syntax inagents/dist/index.d.ts.