Skip to content

Conversation

@tinalenguyen
Copy link
Member

error will be thrown if file_search_store_names is not provided, rest are optional

@chenghao-mou chenghao-mou requested a review from a team January 2, 2026 06:01
Copy link
Member

@chenghao-mou chenghao-mou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It is interesting that they report the error with a 400 instead of a client-side one.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@tinalenguyen tinalenguyen merged commit 07b9f14 into main Jan 2, 2026
17 of 19 checks passed
@tinalenguyen tinalenguyen deleted the tina/edit-gemini-filesearch-args branch January 2, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants