improve should_discard check#5676
Open
chenghao-mou wants to merge 4 commits intomainfrom
Open
Conversation
longcw
reviewed
May 8, 2026
Comment on lines
+518
to
+524
| # warn once per skipping window | ||
| if skip_stt and not self._skip_stt_warning_started: | ||
| self._skip_stt_warning_started = True | ||
| logger.warning("skipping stt due to aec warmup or discard_audio_if_uninterruptible") | ||
| elif not skip_stt and self._skip_stt_warning_started: | ||
| self._skip_stt_warning_started = False | ||
|
|
Contributor
There was a problem hiding this comment.
should we move this to the agent activity and add both logs for discard started and ended?
Member
Author
There was a problem hiding this comment.
Changed this to info too. Since normally it is expected when aec or discard are enabled.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.