-
Notifications
You must be signed in to change notification settings - Fork 180
Single PC improvements #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pblazej
wants to merge
8
commits into
main
Choose a base branch
from
blaze/single-pc-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d93000e
perf(connect): skip 20ms negotiate debounce on initial connect
pblazej cee9c73
refactor(tracing): unify connect-time dc_open and add offer_sent split
pblazej ec1aba4
chore: add changeset for single-PC connect speedup
pblazej 60a5098
chore(connect): wait for connect-time data channels before returning
pblazej 90e9ce1
refactor(tracing): drop dataChannelDidOpen delegate
pblazej 13998ba
revert(tracing): drop dc_open instrumentation
pblazej 769386a
feat(connect): add Room.waitUntilDataChannelsOpen()
pblazej e531799
chore(connect): cancellation check after resumeQueues
pblazej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| patch type="fixed" "Faster initial connect in single peer connection mode by skipping an unnecessary 20ms negotiate debounce" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Copyright 2026 LiveKit | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import Foundation | ||
|
|
||
| public extension Room { | ||
| /// Waits until the connect-time data channels have opened. | ||
| /// | ||
| /// ``connect(url:token:connectOptions:roomOptions:)`` returns once the | ||
| /// primary peer connection reaches DTLS completion. Data channels share | ||
| /// the same SCTP transport and typically open within a few milliseconds | ||
| /// after, but the open event is observed asynchronously. Await this | ||
| /// method when full handshake completion (readiness to send and receive | ||
| /// data) must be observed before proceeding. | ||
| /// | ||
| /// Records a `dc_open` event on ``connectSpan`` when the data channels open. | ||
| /// | ||
| /// - Parameters: | ||
| /// - timeout: The timeout for the operation. | ||
| /// - Throws: `LiveKitError` if data channels do not open within the timeout. | ||
| @discardableResult | ||
| func waitUntilDataChannelsOpen(timeout: TimeInterval = .defaultPublisherDataChannelOpen) async throws -> Self { | ||
| guard let pair = _state.transport?.connectDataChannelPair( | ||
| publisher: publisherDataChannel, | ||
| subscriber: subscriberDataChannel | ||
| ) else { | ||
| return self | ||
| } | ||
| try await pair.openCompleter.wait(timeout: timeout) | ||
| connectSpan?.record("dc_open") | ||
| return self | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moved to 769386a to make it consistent with the spec, I'm not sure if we should drop this data point if that's not really awaitable from Swift.
I may re-evaluate the spec (and other SDKs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I'm more for dropping it...