TEL-562: make media timeout detection more deterministic#675
Open
hechen-eng wants to merge 3 commits intomainfrom
Open
TEL-562: make media timeout detection more deterministic#675hechen-eng wants to merge 3 commits intomainfrom
hechen-eng wants to merge 3 commits intomainfrom
Conversation
dennwc
reviewed
May 6, 2026
| } | ||
| p.timeoutInitial.Store(&opts.MediaTimeoutInitial) | ||
| p.timeoutGeneral.Store(&opts.MediaTimeout) | ||
| go p.timeoutLoop(tid, func() { |
Contributor
There was a problem hiding this comment.
Please keep the tid. It helps find stuck media loops for specific calls.
Contributor
Author
There was a problem hiding this comment.
I don't see tid is actually used in the old code. Do we still need it 🤔
| "sinceLast", time.Since(lastTime), | ||
| "sinceStart", time.Since(startTime), | ||
| ) | ||
| if curPackets == startPackets { |
Contributor
There was a problem hiding this comment.
Better keep this one, it helped find quite a few random deadlocks on the media path.
Contributor
Author
There was a problem hiding this comment.
we now check whether it's isInitial using lastPacketTime.Before(startTime), which should be sufficient? logs are also preserved from line 520 to 525
hechen-eng
force-pushed
the
stable-media-timeout
branch
from
da2fc8c to
ddbef65
Compare
Contributor
Author
|
made the change to reset the timer by comparing with lastPacketTime 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.