Move macro registration from register() to boot()#20
Closed
gcavanunez wants to merge 1 commit intolivewire:mainfrom
Closed
Move macro registration from register() to boot()#20gcavanunez wants to merge 1 commit intolivewire:mainfrom
register() to boot()#20gcavanunez wants to merge 1 commit intolivewire:mainfrom
Conversation
Collaborator
|
Hey @gcavanunez, Thanks for the PR, this will be fixed in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes icon component registration issue when using Blaze with
blade-ui-kit/blade-iconsand potential race conditional related to registration with children packages likemallardduck/blade-lucide-icons.The Problem
BlazeServiceProvider::register()calls$this->app->make('view')to register macros, which resolves theViewFactorybefore potentially all icon packages have registered their icon sets. This breaks packages that usecallAfterResolving(ViewFactory, callback).The Fix
Move macro registration from
register()toboot(). This ensures all service providers complete theirregister()phase before ViewFactory is resolved.Related