ir: allow callee of function type in NewCall#74
Closed
mewmew wants to merge 1 commit intollir:masterfrom
Closed
Conversation
Prior to this commit, the callee had to be of pointer to function type (as is the type of functions declared in the global scope of the module). However, to allow inline asm values to have function type instead of pointer to function type, the type checking of NewCall is relaxed. Fixes llir#33.
Member
Author
|
DO NOT MERGE An alternative to this PR is treat to the type of inline asm values as pointer to function type. This may be a better approach (where we would update the asm parser, and perhaps add documentation to the IR package). The benefit would be that callee's always have pointer to function type instead of either function type or pointer to function type. I guess we just have to decide where we try to handle inconsistencies. Either approach is fine by me, so long as we have the discussion prior. (ref: #33 (comment)) cc: @pwaller :) |
This was referenced Mar 3, 2019
Member
Author
|
Resolved, see #33 (comment) for further details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the callee had to be of pointer
to function type (as is the type of functions declared
in the global scope of the module).
However, to allow inline asm values to have function
type instead of pointer to function type, the type
checking of NewCall is relaxed.
Fixes #33.