Skip to content

Comments

Add messagepack array prefix so that multiple records will be processed.#4

Merged
adikus merged 1 commit intologtail:mainfrom
section:messagepack-array-prefix
Aug 31, 2022
Merged

Add messagepack array prefix so that multiple records will be processed.#4
adikus merged 1 commit intologtail:mainfrom
section:messagepack-array-prefix

Conversation

@glennslaven
Copy link
Contributor

See https://github.com/msgpack/msgpack/blob/master/spec.md#array-format-family.

Without the 0xdd<size> prefix, the server only processes the first record in the chunk sent.

Also adds a couple of debug log lines to make diagnosing issues easier.

Resolves #3

See https://github.com/msgpack/msgpack/blob/master/spec.md#array-format-family.

Without the `0xdd<size>` prefix, the server only processes the first record in the chunk sent.

Also adds a couple of debug log lines to make diagnosing issues easier.

Resolves logtail#3
@adikus
Copy link
Contributor

adikus commented Aug 30, 2022

Hi @glennslaven!
Thanks for this! I'll give this a review in a bit.

@adikus adikus merged commit 778fc64 into logtail:main Aug 31, 2022
@adikus
Copy link
Contributor

adikus commented Aug 31, 2022

Thanks! Works like a charm!

@adikus
Copy link
Contributor

adikus commented Aug 31, 2022

Released as 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plugin doesn't send all the events

2 participants