Skip to content

Conversation

@bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Jul 3, 2025

Description

This PR introduces a dynamic second tab in the tab bar. 🛠️

For users who have remote functionality enabled (i.e., remoteType is not .none), the second tab will continue to show the Remote view.

For users who do not use the remote features (remoteType is .none), this change restores the Alarms view to the second tab. This provides these users with quick and convenient access to alarm configuration without having to navigate through the settings menu.

This implementation listens for changes to the remoteType setting and updates the tab bar in real-time.

@bjorkert bjorkert requested a review from marionbarker July 3, 2025 19:06
@bjorkert bjorkert linked an issue Jul 3, 2025 that may be closed by this pull request
Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limited addition

This only covers part the request (from Issue #333) but I understand that expanded capability will need to wait.

This code change enables users who do not use remote control to have the alarm button show up on the task bar. It limits users to either remote control (if enabled) or alarm button (only if remote control is disabled) to show up in the second spot of the task bar.

Code Review

Code changes appear appropriate for the limited change provided.

Test

The alarm button shows up in the second spot of the task bar when remote control is set to none.

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - there is a linting change that was not committed. Might want to fix that before merging.

LoopFollow/ViewControllers/AlarmViewController.swift

@bjorkert
Copy link
Contributor Author

bjorkert commented Jul 5, 2025

Thanks, i re-built and pushed the result of the Lint.

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the linting fix. Approving again.

@bjorkert bjorkert merged commit 60a06d9 into dev Jul 5, 2025
@bjorkert bjorkert deleted the alarm-tab branch July 5, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Select buttons in toolbar

3 participants