build(build): upgrade Mocha to v6 prerelease by boneskull · Pull Request #2281 · loopbackio/loopback-next

boneskull · 2019-01-24T00:55:02Z

also replaces legacy mocha.opts with new .mocharc.json

Checklist

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

boneskull · 2019-01-24T00:56:31Z

I think commitizen may be misconfigured; wasn't sure which type(scope) to use here as it disallowed anything I was trying for scope (e.g., build(test))

boneskull · 2019-01-24T00:57:57Z

cla bot seems kind of busted too; typing "I AGREE" then clicking the button didn't seem to do anything and I received no confirmation (but it did work)

raymondfeng · 2019-01-24T01:41:31Z

@boneskull Thank you for the PR to verify if our build works with mocha 6.x. The CI fails due to the following error:

/home/travis/build/strongloop/loopback-next/packages/build/node_modules/mocha/lib/cli/config.js:63
    throw new Error(`failed to parse ${filepath}: ${err}`);
    ^
Error: failed to parse /home/travis/build/strongloop/loopback-next/packages/build/config/.mocharc.json: Error: ENOENT: no such file or directory, open '/home/travis/build/strongloop/loopback-next/packages/build/config/.mocharc.json'
    at exports.loadConfig.filepath (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/mocha/lib/cli/config.js:63:11)
    at loadRc (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/mocha/lib/cli/options.js:197:21)
    at loadOptions (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/mocha/lib/cli/options.js:267:20)
    at Object.<anonymous> (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/mocha/bin/mocha:24:14)
    at Module._compile (module.js:653:30)
    at Module.replacementCompile (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/nyc/node_modules/append-transform/index.js:58:13)
    at Module.replacementCompile (/home/travis/build/strongloop/loopback-next/packages/build/node_modules/nyc/node_modules/append-transform/index.js:58:13)
    at Module._extensions..js (module.js:664:10)
    at /home/travis/build/strongloop/loopback-next/packages/build/node_modules/nyc/node_modules/append-transform/index.js:62:4
    at /home/travis/build/strongloop/loopback-next/packages/build/node_modules/nyc/node_modules/append-transform/index.js:62:4

Is .mocharc.json required now? IMO, it should be optional.

bajtos

This is great, thank you @boneskull for upgrading our project to the upcoming Mocha version!

Is there any ETA on when Mocha v6 will be released? I'd rather not depend on pre-release versions and wait with landing this pull request until mocha@6.0.0 is released.

bajtos · 2019-01-24T07:59:44Z

packages/build/test/integration/scripts.integration.js

  function cleanup() {
    var run = require('../../bin/run-clean');
-    run(['node', 'bin/run-clean', 'test/mocha.opts']);
+    run(['node', 'bin/run-clean', 'test/.mocharc.json']);


AFAICT, .mocharc.json is placed in project root, not in test directory.

Suggested change

run(['node', 'bin/run-clean', 'test/.mocharc.json']);

run(['node', 'bin/run-clean', '.mocharc.json']);

bajtos · 2019-01-24T08:06:08Z

packages/build/config/mocha.opts

--require source-map-support/register
--recursive
--exit
--reporter dot


I believe we have two Mocha configurations:

The config in packages/build that's primarily used inside loopback-next monorepo. It's important to include --exit and --reporter dot options.

The template in packages/cli/generators/project/templates/test/mocha.opts that's used when scaffolding new LB4 project.

IIUC, your pull request is correctly reworking the template from mocha.opts to .mocharc.json, but completely removing the config used by loopback-next. Please preserve both sets of configuration. Maybe you just forgot to commit the file packages/build/config/.mocharc.json? I see you are referring to it in multiple places, but don't see that file in the pull request.

While we are discussing this part, can we remove the dot prefix from the filename please, to make the file easier to find? Dot files are considered as "hidden" on Unix-like systems. It makes a lot of sense to use a dot file in project root (.mocharc.json), but I find it counter-productive to use a dot file elsewhere in project directory tree.

I am proposing the following filename:

packages/build/config/mocharc.json

I named it .mocharc.json because the other dotfiles in that directory begin with a dot (e.g., .nycrc, .prettierrc).

I think I'd prefer to keep the name as it is for consistency and to avoid confusion between .mocharc.json and mocharc.json?

I named it .mocharc.json because the other dotfiles in that directory begin with a dot (e.g., .nycrc, .prettierrc).
I think I'd prefer to keep the name as it is for consistency and to avoid confusion between .mocharc.json and mocharc.json?

Fair enough 👍

I believe this part was not addressed yet:

IIUC, your pull request is correctly reworking the template from mocha.opts to .mocharc.json, but completely removing the config used by loopback-next. Please preserve both sets of configuration. Maybe you just forgot to commit the file packages/build/config/.mocharc.json? I see you are referring to it in multiple places, but don't see that file in the pull request.

boneskull · 2019-01-24T18:38:19Z

fix paths
rename non-root .mocharc.json to mocharc.json

boneskull · 2019-01-24T18:38:55Z

Is there any ETA on when Mocha v6 will be released? I'd rather not depend on pre-release versions and wait with landing this pull request until mocha@6.0.0 is released.

There's no real ETA, but I think I'm going to try to get another prerelease out today.

boneskull · 2019-01-24T18:39:19Z

@raymondfeng

Is .mocharc.json required now? IMO, it should be optional.

It's not required unless the path is explicitly given via --config <path>.

also replaces legacy mocha.opts with new .mocharc.json

raymondfeng · 2019-01-24T21:20:12Z

@boneskull Please port mocha.opts to .mocharc.json and commit it into the PR.

raymondfeng · 2019-01-30T18:02:22Z

Enhanced as #2309

boneskull requested review from bajtos and raymondfeng as code owners January 24, 2019 00:55

bajtos suggested changes Jan 24, 2019

View reviewed changes

build(build): upgrade Mocha to v6 prerelease

2cbfa30

also replaces legacy mocha.opts with new .mocharc.json

boneskull force-pushed the mocha-v6 branch from ab9de45 to 2cbfa30 Compare January 24, 2019 20:24

raymondfeng mentioned this pull request Jan 30, 2019

chore(build): use new config format for mocha v6.x #2309

Merged

7 tasks

raymondfeng closed this Jan 30, 2019

	run(['node', 'bin/run-clean', 'test/.mocharc.json']);
	run(['node', 'bin/run-clean', '.mocharc.json']);

Conversation

boneskull commented Jan 24, 2019

Checklist

Uh oh!

boneskull commented Jan 24, 2019

Uh oh!

boneskull commented Jan 24, 2019

Uh oh!

raymondfeng commented Jan 24, 2019

Uh oh!

bajtos left a comment

Choose a reason for hiding this comment

Uh oh!

bajtos Jan 24, 2019

Choose a reason for hiding this comment

Uh oh!

bajtos Jan 24, 2019

Choose a reason for hiding this comment

Uh oh!

boneskull Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boneskull Jan 24, 2019

Choose a reason for hiding this comment

Uh oh!

bajtos Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

bajtos Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

boneskull commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boneskull commented Jan 24, 2019

Uh oh!

boneskull commented Jan 24, 2019

Uh oh!

raymondfeng commented Jan 24, 2019

Uh oh!

raymondfeng commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

boneskull Jan 24, 2019 •

edited

Loading

boneskull commented Jan 24, 2019 •

edited

Loading