Skip to content

Fix login UI issue #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krusche merged 1 commit into from
May 29, 2025
Merged

Fix login UI issue #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/webapp/app/home/home.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
<h3>Welcome to the Artemis Benchmarking Tool</h3>
<p class="lead">This application can be used for performance testing of Artemis.</p>
<div>
@if (account() !== null) {
@if (account(); as accountRef) {
<div class="alert alert-success">
@if (account(); as accountRef) {
<span id="home-logged-message">You are logged in as user &quot;{{ accountRef.login }}&quot;.</span>
}
<span id="home-logged-message">You are logged in as user &quot;{{ accountRef.login }}&quot;.</span>
</div>
} @else {
<div class="alert alert-warning">
<span>You are not signed in. Click here to </span>
<a class="alert-link" (click)="login()" (keydown.enter)="login()" tabindex="0">sign in</a>
<a class="alert-link" href="javascript:void(0)" (click)="login()" (keyup.enter)="login()">sign in</a>

@jfr2102 jfr2102 May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the href and keyup.enter event improves accessablity and avoid eslint accessablity errors

Copilot AI May 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a button element for the login action instead of an anchor tag with 'javascript:void(0)' to provide better semantic meaning and accessibility for assistive technologies.

Suggested change
<a class="alert-link" href="javascript:void(0)" (click)="login()" (keyup.enter)="login()">sign in</a>
<button class="alert-link" (click)="login()" (keyup.enter)="login()">sign in</button>

Copilot uses AI. Check for mistakes.
</div>
}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/main/webapp/app/layouts/navbar/navbar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</a>
</li>
<!-- jhipster-needle-add-element-to-menu - JHipster will add new menu items here -->
@if (account() !== null) {
@if (account()) {
<li
ngbDropdown
class="nav-item dropdown pointer"
Expand Down