Skip to content

Gracefully handle missing irb/notifier#1663

Merged
lsegal merged 3 commits into
mainfrom
ls/graceful-irb-notifier
Mar 24, 2026
Merged

Gracefully handle missing irb/notifier#1663
lsegal merged 3 commits into
mainfrom
ls/graceful-irb-notifier

Conversation

@lsegal

@lsegal lsegal commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Fixes #1649
Fixes #1636
Fixes #1645

@lsegal lsegal self-assigned this Mar 24, 2026
@lsegal lsegal merged commit de5b786 into main Mar 24, 2026
48 checks passed
@lsegal lsegal deleted the ls/graceful-irb-notifier branch March 24, 2026 23:53
@noraj

noraj commented Apr 11, 2026

Copy link
Copy Markdown

This PR does not bring 100% of Ruby 4.0 support as seen in the v0.9.39 release note.

Add support for Ruby 4.0 (#1663)

Indeed, if using markdown formatting with commonmarker, it's still not possible to use yard and ruby 4.0. Because #1528 is not fixed, yard still only support commonmarker 0.9.x and not commonmarker 1.x or commonmarker 2.x. But because commonmarker 0.9.x does not support ruby 4.0 then yard does not support ruby 4.0. For 100% ruby 4.0 support, yard should support commonmarker 1.x and 2.x and close #1528. Is has been nearly two years that #1540 have not received any update.

@lsegal

lsegal commented Apr 11, 2026

Copy link
Copy Markdown
Owner Author

Feedback was already provided on #1540 that was never addressed. That PR should probably be closed as stale. It would be easy to open a PR that addresses the feedback by creating a proper compatibility layer and does not break backward compatibility. You're free to open such a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please fix your dependencies Add irb as dependency to avoid warning in Ruby v4.0

2 participants