Improve JSON correctness for math.huge, nan, and massive serialization parts#1105
Open
Nicell wants to merge 2 commits into
Open
Improve JSON correctness for math.huge, nan, and massive serialization parts#1105Nicell wants to merge 2 commits into
Nicell wants to merge 2 commits into
Conversation
Co-authored-by: Noah Winn <111249648+nwinn-student@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
@std/jsoncorrectness around two serialization edge cases:math.huge,-math.huge,math.nan) instead of emitting invalid JSON tokensnullif we don't want to be as annoying with errors and match what some serializers do, curious if there are any opinions on this