Skip to content

Use string_view for server responses to remove an extra copy#1106

Merged
Nicell merged 1 commit into
luau-lang:primaryfrom
Nicell:string-view-response
May 18, 2026
Merged

Use string_view for server responses to remove an extra copy#1106
Nicell merged 1 commit into
luau-lang:primaryfrom
Nicell:string-view-response

Conversation

@Nicell
Copy link
Copy Markdown
Collaborator

@Nicell Nicell commented May 17, 2026

Use std::string_view for server response bodies and headers to avoid an extra std::string allocation/copy before sending the response.

@Nicell Nicell force-pushed the string-view-response branch from 5d2a493 to c11c4a8 Compare May 17, 2026 17:55
Copy link
Copy Markdown
Collaborator

@Vighnesh-V Vighnesh-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@Nicell Nicell merged commit d849d6a into luau-lang:primary May 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants