Split net library into client and server#717
Closed
Nicell wants to merge 1 commit into
Closed
Conversation
aatxe
requested changes
Jan 13, 2026
Comment on lines
+237
to
+264
| int luaopen_net(lua_State* L) | ||
| { | ||
| globalCurlInit(); | ||
|
|
||
| luaL_register(L, "net", net::lib); | ||
|
|
||
| return 1; | ||
| } | ||
|
|
||
| int luteopen_net(lua_State* L) | ||
| { | ||
| globalCurlInit(); | ||
|
|
||
| lua_createtable(L, 0, std::size(net::lib)); | ||
|
|
||
| for (auto& [name, func] : net::lib) | ||
| { | ||
| if (!name || !func) | ||
| break; | ||
|
|
||
| lua_pushcfunction(L, func, name); | ||
| lua_setfield(L, -2, name); | ||
| } | ||
|
|
||
| lua_setreadonly(L, -1, 1); | ||
|
|
||
| return 1; | ||
| } |
Member
There was a problem hiding this comment.
Environment setup seems to be broken now with how they're split. I want to make all of the modules/submodules for the runtime libraries more uniform here, but in general, we should have open for @lute/net/client and open for @lute/net/server and an open for @lute/net that, at the very least, exposes those two tables as client and server within it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to get websockets in upstream, as I've been using my branch of it for a bit with success. First, though, splitting net into server and client should make it cleaner and easier to review the upcoming websocket PRs... Also the file was getting really long.