Skip to content

chore!: upgrade koa/router package#1818

Open
jeengbe wants to merge 2 commits intolukeautry:masterfrom
jeengbe:je-upgrade-koa-router
Open

chore!: upgrade koa/router package#1818
jeengbe wants to merge 2 commits intolukeautry:masterfrom
jeengbe:je-upgrade-koa-router

Conversation

@jeengbe
Copy link

@jeengbe jeengbe commented Dec 15, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #1817

Potential Problems With The Approach

This will require users to upgrade @types/koa__router -> @koa/router, which may include breaking changes outside the direct scope of tsoa - e.g. in the context or request object.

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there jeengbe 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@jeengbe
Copy link
Author

jeengbe commented Dec 15, 2025

Perhaps I need to bump the versions for the tests to work in CI? They run just fine locally.

@jeengbe
Copy link
Author

jeengbe commented Dec 16, 2025

I have no idea why this doesn't work. Have you seen this before, WoH?

@jrabmer
Copy link

jrabmer commented Feb 26, 2026

Hi, is there any update on this pull request? Would love to be able to upgrade to the new koa router package.

I tried out this pull request locally on my machine (ubuntu) and the tests also seem to run fine. One thing i noticed is that the author seemed to have run npm install instead of yarn install. I am not sure if that is enough of a difference though.

One thing that could be looked at is that the Author imports the default export of the koa router. This is declare const Router: RouterConstructor;. Perhaps a better import would be type RouterInstance. ? Or importing the default export as a value instead of a type would also maybe fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade @koa/router (breaking change) with v7

2 participants