Skip to content

feat: make errors more visible with vim.notify#432

Open
teto wants to merge 1 commit into
mainfrom
teto/notify-on-error
Open

feat: make errors more visible with vim.notify#432
teto wants to merge 1 commit into
mainfrom
teto/notify-on-error

Conversation

@teto

@teto teto commented Jun 28, 2024

Copy link
Copy Markdown
Member

the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed

I haven't tested yet. Just putting it out there to see what people think

the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed
@github-actions

Copy link
Copy Markdown
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb enabled auto-merge (squash) June 30, 2024 01:19

@mrcjkb mrcjkb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we'd also want this for :Rocks update?

@vhyrro

vhyrro commented Jul 5, 2024

Copy link
Copy Markdown
Member

Wait, why is there a green tick at the end, if there were errors during the process? I feel like that should be the meat of this problem. I personally feel like a notify and a message in fidget.nvim is slightly too much :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants