feat: make errors more visible with vim.notify#432
Open
teto wants to merge 1 commit into
Open
Conversation
the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed
Contributor
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
reviewed
Jul 1, 2024
mrcjkb
left a comment
Member
There was a problem hiding this comment.
I suppose we'd also want this for :Rocks update?
Member
|
Wait, why is there a green tick at the end, if there were errors during the process? I feel like that should be the meat of this problem. I personally feel like a notify and a message in fidget.nvim is slightly too much :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the spinner is too discrete and there is a green tick once it finishes so at first I thought the install had succeeded but paying closer attention, the message up/down of it said install had failed
I haven't tested yet. Just putting it out there to see what people think