Skip to content

Removed unnecessary symbol from Playdate std#84

Merged
alerque merged 1 commit into
lunarmodules:masterfrom
DidierMalenfant:removed-playdate-exit
Dec 19, 2022
Merged

Removed unnecessary symbol from Playdate std#84
alerque merged 1 commit into
lunarmodules:masterfrom
DidierMalenfant:removed-playdate-exit

Conversation

@DidierMalenfant
Copy link
Copy Markdown

@DidierMalenfant DidierMalenfant commented Dec 18, 2022

This, it turns out, is not needed.

@alerque
Copy link
Copy Markdown
Member

alerque commented Dec 18, 2022

Thanks for taking the time to contribute.

Any idea why this was included in the first place? I don't use Playdate myself so I'm not very familiar with how the SDK works or why this would be needed or not needed. I'm willing to take contributors word for it but a little explanation or links to anything relevant before I pull the trigger might be nice.

@DidierMalenfant
Copy link
Copy Markdown
Author

Any idea why this was included in the first place?

It was purely an error on my part. I came across some code that used this method but it turns out that it's not a standard SDK one, just one they added to the namespace elsewhere.

@alerque
Copy link
Copy Markdown
Member

alerque commented Dec 19, 2022

Oh hey there! I got tripped up because GitHub is trying to say you are a first time contributor. I didn't lookup that the Playdate functions were added by you in the first place.

@alerque alerque merged commit 629c262 into lunarmodules:master Dec 19, 2022
Aire-One pushed a commit to Aire-One/luacheck that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants