Fix compatibility issue with Go before 1.11#575
Open
gonutz wants to merge 1 commit intolxn:masterfrom
gonutz:master
Open
Fix compatibility issue with Go before 1.11#575gonutz wants to merge 1 commit intolxn:masterfrom gonutz:master
gonutz wants to merge 1 commit intolxn:masterfrom
gonutz:master
Conversation
Instead of using strings.ReplaceAll we just use strings.Replace with -1 as the last argument, which does the same but is a tiny bit less readable. The value of backwards compatibility is more important.
|
I also encountered this problem, hope to merge quickly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using strings.ReplaceAll we just use strings.Replace with -1
as the last argument, which does the same but is a tiny bit less
readable. The value of backwards compatibility is more important.