Repository navigation
Conversation
The factory pinmap puts signal A on the lower GPIO of each connector: Grove12 GPIO37 (A) / GPIO38 (B), Grove13 GPIO0 (A, SDA) / GPIO1 (B, SCL) and Grove14 GPIO26 (A) / GPIO27 (B). The catalog had the two pins of each connector the other way round; the note on each pin already stated the order the pinmap uses. Grove15 (GPIO3 / GPIO2) is correct and unchanged. Nothing in M5Unified depends on this, the catalog is the only wrong copy. Signed-off-by: tinyu <tinyu0806@gmail.com>
|
Before merging, could you check the signal order on the connectors? We don't have the hardware here, so I can't tell from this side, but the result affects which way this change should go. In the catalog,
So the signal next to 5V is Existing ports follow this order. Port B and Port C are usually on a base or module rather than on the core, so those are the products listed for them:
The ExtPort documentation uses the same numbering for its switchable ports: M5Unified uses the same order: Could you confirm these on the actual connectors, going from GND towards the far end (GND, 5V, next, last)?
If SDA and TX are next to 5V, Grove12 and Grove13 already match the existing boards, and swapping them would put them in the opposite order. In that case, the connectors where signal A is on If SCL and RX are next to 5V, this board differs from the existing ones, and I'd like to record that in the connector note as well. |
Problem
The board catalog for the StampP4X Hub has the two signals of Grove12, Grove13 and Grove14 swapped. The factory pinmap puts signal A on the lower GPIO of each connector:
The catalog had the two pins of each connector the other way round, while the per-pin note already stated the order the pinmap uses. Grove15 (GPIO3 / GPIO2) is correct and unchanged.
Changes
extras/board_spec/boards/m5stampp4xhub.json: swap the A/B pin of Grove12, Grove13 and Grove14, keeping each pin's signal role and note.extras/board_spec/dist/board_spec_editor.html(node build/bundle.js).Note
Grove13 is the one that matters in practice: it is the external I2C port on the system bus, so a module wired per the old catalog would be read with SDA and SCL swapped. Nothing in M5Unified depends on this; the catalog is the only wrong copy.
Verification
node cli/spec.js check→check passed: 63 board(s), 90 resolved combination(s)npm test→ 219 pass, 0 fail