Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main(greasyfork).user.js
Original file line number Diff line number Diff line change
Expand Up @@ -620,8 +620,8 @@
function transTimeElement(el) {
const text = el.textContent;
if (!text) return;
// 移除开头的"on"
const result = text.replace(/^on/, "");
// 移除时间文本中的"on"
const result = text.replace(/\bon\s+/gi, (match, offset) => offset === 0 ? " " : "");
if (result !== text) {
el.textContent = result;
}
Expand Down
4 changes: 2 additions & 2 deletions main(nju.edu).user.js
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,8 @@
// 获取时间文本
const text = element.textContent;
if (!text) return;
// 移除开头的"on"
const result = text.replace(/^on/, "");
// 移除时间文本中的"on"
const result = text.replace(/\bon\s+/gi, (match, offset) => offset === 0 ? " " : "");
if (result !== text) {
element.textContent = result; // 应用翻译
}
Expand Down
4 changes: 2 additions & 2 deletions main.user.js
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,8 @@
// 获取时间文本
const text = element.textContent;
if (!text) return;
// 移除开头的"on"
const result = text.replace(/^on/, "");
// 移除时间文本中的"on"
const result = text.replace(/\bon\s+/gi, (match, offset) => offset === 0 ? " " : "");
if (result !== text) {
element.textContent = result; // 应用翻译
}
Expand Down
4 changes: 2 additions & 2 deletions main_zh-TW.user.js
Original file line number Diff line number Diff line change
Expand Up @@ -991,8 +991,8 @@
// 獲取時間文本
const text = element.textContent;
if (!text) return;
// 移除開頭的"on"
const result = text.replace(/^on/, "");
// 移除時間文本中的"on"
const result = text.replace(/\bon\s+/gi, (match, offset) => offset === 0 ? " " : "");
if (result !== text) {
element.textContent = result; // 應用翻譯
}
Expand Down
34 changes: 34 additions & 0 deletions test/issue-773-regression.test.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const test = require('node:test');
const vm = require('node:vm');

const runtimeScripts = [
'main.user.js',
'main(nju.edu).user.js',
'main_zh-TW.user.js',
'main(greasyfork).user.js',
];

function extractTimeTranslator(source) {
const start = source.indexOf('function transTimeElement(');
assert.notEqual(start, -1, 'transTimeElement should exist in the userscript');

const end = source.indexOf('\n /**', start);
assert.notEqual(end, -1, 'transTimeElement should end before the next documented function');
return source.slice(start, end).trimEnd();
}

for (const fileName of runtimeScripts) {
test(`${fileName} removes the leftover on from translated timestamps`, () => {
const filePath = path.join(__dirname, '..', fileName);
const source = fs.readFileSync(filePath, 'utf8');
const translateTime = vm.runInNewContext(`(${extractTimeTranslator(source)})`);
const element = { textContent: '打开于 on 7月15日' };

translateTime(element);

assert.equal(element.textContent, '打开于 7月15日');
});
}