Repository navigation
fix(android): drop the duplicate OSGi manifest that breaks the APK merge - #9247
Open
peterchinman wants to merge 1 commit into
Open
peterchinman wants to merge 1 commit into
peterchinman wants to merge 1 commit into
Conversation
The native call tracing dependencies added jspecify and the OpenTelemetry exporter, which both ship META-INF/versions/9/OSGI-INF/MANIFEST.MF. Gradle refuses the duplicate in mergeReleaseJavaResource, so Android builds from main fail. Android never reads OSGi metadata; exclude it from the packaged resources.
peterchinman
added
the
skip-android-update
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Android release builds from
mainfail for every target since the native call tracing change (#9142):Both libraries ship the same OSGi module manifest, and Gradle refuses to package duplicate Java resources.
Part of MACRO-4347.
What
apps/web/tauri/src-tauri/gen/android/app/build.gradle.kts: excludeMETA-INF/versions/9/OSGI-INF/MANIFEST.MFfrom packaged resources. Android never reads OSGi metadata, so dropping it changes nothing at runtime; the OpenTelemetry classes are still packaged. Excluding just this path, notpickFirstor a wildcard overMETA-INF, keeps any future real conflict visible.skip-android-update: the change only affects packaging, so it neither needs a new versionCode nor raises the native build floor.