Fix Jegantha, the Wellspring mana payment calculations#14628
Open
matoro wants to merge 1 commit intomagefree:masterfrom
Open
Fix Jegantha, the Wellspring mana payment calculations#14628matoro wants to merge 1 commit intomagefree:masterfrom
matoro wants to merge 1 commit intomagefree:masterfrom
Conversation
The issue seems to be that `ManaCondition.apply()` is called at multiple points: first passing the entire `ManaCosts` of the overall cost, then passing each individual `ManaCost` sub-cost. The first call is effectively just checking whether the conditional mana can contribute towards paying the cost at all. So we can just allow it there, and then filter more granularly during the follow-up calls where each sub-cost is checked. Fixes magefree@f0ca05e Fixes magefree#9796
Contributor
|
That fix is embarrassingly simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue seems to be that
ManaCondition.apply()is called at multiple points: first passing the entireManaCostsof the overall cost, then passing each individualManaCostsub-cost. The first call is effectively just checking whether the conditional mana can contribute towards paying the cost at all. So we can just allow it there, and then filter more granularly during the follow-up calls where each sub-cost is checked.Fixes f0ca05e
Fixes #9796