Prevent double-escaping of relayhost and transport passwords#6962
Draft
Prevent double-escaping of relayhost and transport passwords#6962
Conversation
Co-authored-by: DerLinkman <62480600+DerLinkman@users.noreply.github.com>
Co-authored-by: DerLinkman <62480600+DerLinkman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix special characters escaping in passwords
Prevent double-escaping of relayhost and transport passwords
Dec 12, 2025
Member
|
@copilot Does this have any negative influence not to escape this anymore? |
Contributor
Author
We removed the extra colon escaping only for passwords to stop double-escaping; Postfix accepts literal colons in credentials, so storing them as entered avoids the added backslashes without altering behavior. Username still keeps the single pass escape. Addressed in 4a89078. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
Stops double-escaping of sender-dependent transport credentials by storing relayhost and transport passwords as entered (no second colon escaping) while keeping the existing single-pass username escape.
Affected Containers
Did you run tests?
What did you tested?
php -l data/web/inc/functions.transports.inc.phpWhat were the final results? (Awaited, got)
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.