[WEB-5614] refactor: update styling and structure across various components#8388
Merged
Conversation
…consistency and improved UI
JayashTripathy
changed the title
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
aaryan610
previously approved these changes
Dec 18, 2025
Contributor
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR applies multiple presentational/styling updates across web app UI and Propel components, adds an Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors styling and structure across various UI components, focusing on visual consistency and component architecture improvements. The changes update CSS utility classes, component styling patterns, and introduce new props for enhanced customization.
- Refactored tabs component to introduce a variant system with context provider (though incomplete implementation)
- Updated chart components to use consistent border styling across CartesianGrid
- Enhanced IconButton component with iconClassName prop for better icon customization
- Modernized UI styling patterns across sidebar, layout switcher, and analytics components
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/propel/src/tabs/tabs.tsx | Introduces TabsContext and variant system, updates styling with new border radius and layer backgrounds |
| packages/propel/src/icon-button/icon-button.tsx | Adds iconClassName prop for icon customization |
| packages/propel/src/icon-button/helper.tsx | Adds iconClassName type definition to IconButtonProps |
| packages/propel/src/charts/tree-map/root.tsx | Changes stroke from "currentColor" to "transparent" for cleaner appearance |
| packages/propel/src/charts/scatter-chart/root.tsx | Updates CartesianGrid stroke from alpha-modified variable to direct CSS variable |
| packages/propel/src/charts/line-chart/root.tsx | Updates CartesianGrid stroke styling for consistency |
| packages/propel/src/charts/bar-chart/root.tsx | Updates CartesianGrid stroke styling for consistency |
| packages/propel/src/charts/area-chart/root.tsx | Updates CartesianGrid stroke styling for consistency |
| apps/web/core/components/workspace/sidebar/projects-list.tsx | Refactors buttons to use IconButton component with improved hover states |
| apps/web/core/components/workspace/sidebar/projects-list-item.tsx | Moves transition-transform to iconClassName prop for cleaner separation |
| apps/web/core/components/base-layouts/layout-switcher.tsx | Updates styling patterns and switches from label to i18n_title for translations |
| apps/web/core/components/base-layouts/kanban/group.tsx | Changes background colors from surface-2 to layer-1 for consistency |
| apps/web/core/components/analytics/select/project.tsx | Refactors to use button styling utilities with customButton pattern |
| apps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx | Updates tabs styling and removes explicit background prop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+11
| type TabsContextType = { | ||
| variant?: TabsVariant; | ||
| }; | ||
|
|
||
| const TabsContext = React.createContext<TabsContextType | undefined>(undefined); |
There was a problem hiding this comment.
The TabsContext is created and provided but never consumed. The variant prop is accepted by TabsTrigger but not used in the component implementation. Either the context should be consumed to use the variant from the root component, or it should be removed if not needed.
Comment on lines
+78
to
+82
| { | ||
| className, | ||
| size = "md", | ||
| ...props | ||
| }: React.ComponentProps<typeof TabsPrimitive.Tab> & { size?: "sm" | "md" | "lg"; variant?: TabsVariant }, |
There was a problem hiding this comment.
The variant prop is accepted in the TabsTrigger type signature but is never destructured or used in the component implementation. Either implement the variant functionality or remove it from the type signature.
| "data-[selected]:bg-layer-transparent-active data-[selected]:text-primary data-[selected]:shadow-sm", | ||
| "text-placeholder hover:text-tertiary hover:bg-layer-transparent-hover", | ||
| "flex items-center justify-center p-1 min-w-fit w-full font-medium text-primary outline-none focus:outline-none cursor-pointer transition-all duration-200 ease-in-out rounded-md border border-transparent", | ||
| " data-[selected]:text-primary data-[selected]:shadow-sm data-[selected]:bg-layer-2 data-[selected]:border data-[selected]:border-subtle-1 data-[selected]:raised-200", |
There was a problem hiding this comment.
There are extra spaces at the beginning of this line. Remove the leading space for consistency.
Suggested change
| " data-[selected]:text-primary data-[selected]:shadow-sm data-[selected]:bg-layer-2 data-[selected]:border data-[selected]:border-subtle-1 data-[selected]:raised-200", | |
| "data-[selected]:text-primary data-[selected]:shadow-sm data-[selected]:bg-layer-2 data-[selected]:border data-[selected]:border-subtle-1 data-[selected]:raised-200", |
| "text-placeholder hover:text-tertiary hover:bg-layer-transparent-hover", | ||
| "flex items-center justify-center p-1 min-w-fit w-full font-medium text-primary outline-none focus:outline-none cursor-pointer transition-all duration-200 ease-in-out rounded-md border border-transparent", | ||
| " data-[selected]:text-primary data-[selected]:shadow-sm data-[selected]:bg-layer-2 data-[selected]:border data-[selected]:border-subtle-1 data-[selected]:raised-200", | ||
| "text-placeholder hover:text-tertiary hover:bg-layer-transparent-hover", |
There was a problem hiding this comment.
There are extra spaces in this class string. Remove the double space after 'text-placeholder' for consistency.
Suggested change
| "text-placeholder hover:text-tertiary hover:bg-layer-transparent-hover", | |
| "text-placeholder hover:text-tertiary hover:bg-layer-transparent-hover", |
| const Icon = layout.icon; | ||
| return ( | ||
| <Tooltip key={layout.key} tooltipContent={layout.label} isMobile={isMobile}> | ||
| <Tooltip key={layout.key} tooltipContent={t(layout.i18n_title)} isMobile={isMobile}> |
There was a problem hiding this comment.
The code is accessing layout.i18n_title but this property doesn't exist in the IBaseLayoutConfig interface, which only has key, icon, and label properties. This will cause a runtime error. Use layout.label instead or add the i18n_title property to the BASE_LAYOUTS configuration.
Suggested change
| <Tooltip key={layout.key} tooltipContent={t(layout.i18n_title)} isMobile={isMobile}> | |
| <Tooltip key={layout.key} tooltipContent={t(layout.label)} isMobile={isMobile}> |
Comment on lines
+198
to
+212
| <IconButton | ||
| variant="ghost" | ||
| size="sm" | ||
| icon={ChevronRightIcon} | ||
| onClick={() => toggleListDisclosure(!isAllProjectsListOpen)} | ||
| className="text-placeholder" | ||
| iconClassName={cn("transition-transform", { | ||
| "rotate-90": isAllProjectsListOpen, | ||
| })} | ||
| aria-label={t( | ||
| isAllProjectsListOpen | ||
| ? "aria_labels.projects_sidebar.close_projects_menu" | ||
| : "aria_labels.projects_sidebar.open_projects_menu" | ||
| )} | ||
| > | ||
| <ChevronRightIcon | ||
| className={cn("flex-shrink-0 size-3 transition-all", { | ||
| "rotate-90": isAllProjectsListOpen, | ||
| })} | ||
| /> | ||
| </Disclosure.Button> | ||
| /> |
There was a problem hiding this comment.
The IconButton component is not wrapped with Disclosure.Button. The previous implementation had this button as a Disclosure.Button which is necessary for the Headless UI Disclosure component to function properly. The button needs to be a Disclosure.Button to trigger the disclosure state.
| )} | ||
| > | ||
| <Tabs.List background="layer-2" className={"my-2 overflow-x-auto flex w-fit"}> | ||
| <Tabs.List className={"overflow-x-auto flex w-fit h-7"}> |
There was a problem hiding this comment.
The background prop was removed from Tabs.List, but based on the tabs.tsx implementation, the default background is now 'contained' which applies 'bg-layer-3'. Since this was previously 'layer-2', this change will alter the visual appearance. Verify this is intentional or explicitly set background="contained" for clarity.
Suggested change
| <Tabs.List className={"overflow-x-auto flex w-fit h-7"}> | |
| <Tabs.List background="contained" className={"overflow-x-auto flex w-fit h-7"}> |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/propel/src/icon-button/icon-button.tsx (1)
31-38: Improved class composition with customization support.The refactoring to use
cn()with object-based conditional classes is cleaner and more maintainable. TheiconClassNameis properly merged after the size-based classes, allowing external overrides while maintaining sensible defaults.Optional: Verify icon size mapping for "lg"
Both
size === "base"andsize === "lg"map tosize-4. If "lg" should render a larger icon than "base", consider updating line 34:- "size-4": size === "base" || size === "lg", + "size-4": size === "base", + "size-4.5": size === "lg",If the current behavior is intentional (where "lg" affects button padding but not icon size), then no change is needed.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
apps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx(1 hunks)apps/web/core/components/analytics/select/project.tsx(3 hunks)apps/web/core/components/base-layouts/kanban/group.tsx(1 hunks)apps/web/core/components/base-layouts/layout-switcher.tsx(3 hunks)apps/web/core/components/workspace/sidebar/projects-list-item.tsx(1 hunks)apps/web/core/components/workspace/sidebar/projects-list.tsx(2 hunks)packages/propel/src/charts/area-chart/root.tsx(1 hunks)packages/propel/src/charts/bar-chart/root.tsx(1 hunks)packages/propel/src/charts/line-chart/root.tsx(1 hunks)packages/propel/src/charts/scatter-chart/root.tsx(1 hunks)packages/propel/src/charts/tree-map/root.tsx(1 hunks)packages/propel/src/icon-button/helper.tsx(1 hunks)packages/propel/src/icon-button/icon-button.tsx(2 hunks)packages/propel/src/tabs/tabs.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}
📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
**/*.{ts,tsx,mts,cts}: Useconsttype parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfiesoperator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitisreturn types in filter/check functions
UseNoInfer<T>utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true)blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusingdeclarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" }for import attributes; avoid deprecatedassertsyntax (TypeScript 5.3/5.8+)
Useimport typeexplicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntaxflag
Use.ts,.mts,.ctsextensions inimport typestatements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" }for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSetmethods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy/Map.groupBystandard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers()for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuperin classes (TypeScript 5....
Files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/icon-button/helper.tsxpackages/propel/src/charts/scatter-chart/root.tsxpackages/propel/src/icon-button/icon-button.tsxapps/web/core/components/workspace/sidebar/projects-list.tsxpackages/propel/src/charts/area-chart/root.tsxapps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/charts/bar-chart/root.tsxpackages/propel/src/tabs/tabs.tsxapps/web/core/components/workspace/sidebar/projects-list-item.tsxpackages/propel/src/charts/tree-map/root.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Enable TypeScript strict mode and ensure all files are fully typed
Files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/icon-button/helper.tsxpackages/propel/src/charts/scatter-chart/root.tsxpackages/propel/src/icon-button/icon-button.tsxapps/web/core/components/workspace/sidebar/projects-list.tsxpackages/propel/src/charts/area-chart/root.tsxapps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/charts/bar-chart/root.tsxpackages/propel/src/tabs/tabs.tsxapps/web/core/components/workspace/sidebar/projects-list-item.tsxpackages/propel/src/charts/tree-map/root.tsx
**/*.{js,jsx,ts,tsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier with Tailwind plugin for code formatting, run
pnpm fix:format
Files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/icon-button/helper.tsxpackages/propel/src/charts/scatter-chart/root.tsxpackages/propel/src/icon-button/icon-button.tsxapps/web/core/components/workspace/sidebar/projects-list.tsxpackages/propel/src/charts/area-chart/root.tsxapps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/charts/bar-chart/root.tsxpackages/propel/src/tabs/tabs.tsxapps/web/core/components/workspace/sidebar/projects-list-item.tsxpackages/propel/src/charts/tree-map/root.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately
Files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/icon-button/helper.tsxpackages/propel/src/charts/scatter-chart/root.tsxpackages/propel/src/icon-button/icon-button.tsxapps/web/core/components/workspace/sidebar/projects-list.tsxpackages/propel/src/charts/area-chart/root.tsxapps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/charts/bar-chart/root.tsxpackages/propel/src/tabs/tabs.tsxapps/web/core/components/workspace/sidebar/projects-list-item.tsxpackages/propel/src/charts/tree-map/root.tsx
🧠 Learnings (20)
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use semantic border colors: `border-subtle` for subtle borders and dividers, `border-subtle-1` for slightly more visible borders, `border-strong` for strong emphasis borders, and `border-strong-1` for very strong borders
Applied to files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/charts/scatter-chart/root.tsxpackages/propel/src/charts/area-chart/root.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Sidebar menu items should use transparent backgrounds with hover states like `hover:bg-layer-1-hover` rather than base layer backgrounds, maintaining visual lightness while providing hover feedback
Applied to files:
packages/propel/src/charts/line-chart/root.tsxpackages/propel/src/charts/scatter-chart/root.tsxapps/web/core/components/workspace/sidebar/projects-list.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxpackages/propel/src/tabs/tabs.tsxpackages/propel/src/charts/tree-map/root.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use `-selected` state variants (e.g., `bg-layer-1-selected`) only when there is actual selection logic implemented, or use data attributes like `data-[selected]:bg-layer-1-selected`
Applied to files:
apps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/kanban/group.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-10-09T20:42:31.843Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.
Applied to files:
apps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/layout-switcher.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-05-14T13:16:23.323Z
Learnt from: vamsikrishnamathala
Repo: makeplane/plane PR: 7061
File: web/core/components/workspace-notifications/root.tsx:18-18
Timestamp: 2025-05-14T13:16:23.323Z
Learning: In the Plane project codebase, the path alias `@/plane-web` resolves to the `ce` directory, making imports like `@/plane-web/hooks/use-notification-preview` correctly resolve to files in `web/ce/hooks/`.
Applied to files:
apps/web/core/components/analytics/select/project.tsx
📚 Learning: 2025-10-21T17:22:05.204Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7989
File: apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx:45-46
Timestamp: 2025-10-21T17:22:05.204Z
Learning: In the makeplane/plane repository, the refactor from useParams() to params prop is specifically scoped to page.tsx and layout.tsx files in apps/web/app (Next.js App Router pattern). Other components (hooks, regular client components, utilities) should continue using the useParams() hook as that is the correct pattern for non-route components.
Applied to files:
apps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-12-12T15:20:36.542Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-12T15:20:36.542Z
Learning: Applies to packages/plane/ui/**/*.{ts,tsx} : Build components in `plane/ui` package with Storybook for isolated development
Applied to files:
apps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-10-01T15:30:17.605Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7888
File: packages/propel/src/avatar/avatar.stories.tsx:2-3
Timestamp: 2025-10-01T15:30:17.605Z
Learning: In the makeplane/plane repository, avoid suggesting inline type imports (e.g., `import { Avatar, type TAvatarSize }`) due to bundler compatibility issues. Keep type imports and value imports as separate statements.
Applied to files:
apps/web/core/components/analytics/select/project.tsxapps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use `bg-surface-1`, `bg-surface-2`, or `bg-surface-3` for top-level containers that sit directly on the canvas, such as main content areas, page sections, or primary containers
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Never use `bg-layer-2` or higher for content boxes and cards - always use the matching layer number; the exception for going one level above applies only to interactive form elements
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Pages and routes should use `bg-surface-1` (or appropriate surface variant) as their root container, not `bg-canvas`
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use `bg-layer-1`, `bg-layer-2`, and `bg-layer-3` for nested elements within a surface to create depth, with layer-1 being the closest to the surface, layer-2 on top of layer-1, and layer-3 on top of layer-2
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Do not use `bg-canvas` for page-level backgrounds, nested containers, cards, components, modals, dropdowns, sidebars, or panels
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Headers and main content sections within a page should be part of the same surface container (using semantic borders for visual separation if needed) rather than using separate surface backgrounds
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsxapps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsxpackages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Match layers to their parent surface: use `bg-layer-1` within `bg-surface-1`, use `bg-layer-2` within `bg-surface-2`, and use `bg-layer-3` within `bg-surface-3`
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Do not use hover state classes (e.g., `bg-layer-1-hover`) as base backgrounds - hover states should only be applied with the `hover:` prefix alongside the base background class
Applied to files:
apps/web/core/components/base-layouts/kanban/group.tsx
📚 Learning: 2025-10-09T22:12:26.424Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T22:12:26.424Z
Learning: When `types/react` is installed in a TypeScript project (which is standard for React + TypeScript codebases), React types (React.FC, React.ReactNode, React.ComponentProps, etc.) are globally available by design. These type annotations can and should be used without explicitly importing the React namespace. This is a TypeScript/DefinitelyTyped feature, not codebase-specific configuration.
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-03-11T19:42:41.769Z
Learnt from: janreges
Repo: makeplane/plane PR: 6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use `-active` state variants (e.g., `bg-layer-1-active`) when an element is in a pressed or active state
Applied to files:
packages/propel/src/tabs/tabs.tsx
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use the rare exception to go one level above for visual separation only in interactive form elements (inputs, buttons, switches) within modals - for example, a modal with `bg-surface-1` can use `bg-layer-2` for form inputs to achieve visual distinction
Applied to files:
packages/propel/src/tabs/tabs.tsx
🧬 Code graph analysis (3)
apps/web/core/components/analytics/select/project.tsx (1)
packages/propel/src/icons/arrows/chevron-down.tsx (1)
ChevronDownIcon(6-15)
apps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx (1)
packages/propel/src/tabs/tabs.tsx (1)
Tabs(135-140)
packages/propel/src/tabs/tabs.tsx (1)
packages/propel/src/utils/classname.tsx (1)
cn(63-63)
🪛 GitHub Actions: Build and lint web apps
apps/web/core/components/base-layouts/layout-switcher.tsx
[error] 30-30: TS2339: Property 'i18n_title' does not exist on type 'IBaseLayoutConfig'.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check:format
🔇 Additional comments (18)
packages/propel/src/charts/bar-chart/root.tsx (1)
130-130: LGTM! Consistent grid styling update.The CartesianGrid stroke has been simplified from a semi-transparent alpha-based color to a direct CSS variable reference, improving consistency across chart components.
packages/propel/src/charts/tree-map/root.tsx (1)
19-19: LGTM! Clean treemap borders removed.Setting the stroke to transparent removes cell borders for a cleaner treemap visualization. This is a purely visual enhancement with no functional impact.
packages/propel/src/charts/area-chart/root.tsx (1)
115-115: LGTM! Consistent grid styling.The CartesianGrid stroke has been updated to use a direct CSS variable reference, consistent with the styling improvements applied across other chart components in this PR.
packages/propel/src/charts/scatter-chart/root.tsx (1)
85-85: LGTM! Grid styling aligned.The CartesianGrid stroke has been updated consistently with the other chart components, simplifying the color application to use a direct CSS variable.
packages/propel/src/charts/line-chart/root.tsx (1)
101-101: LGTM! Final grid styling update.The CartesianGrid stroke has been updated to complete the consistent styling improvements across all chart components in the propel package.
apps/web/core/components/base-layouts/kanban/group.tsx (1)
38-46: LGTM! Background styling updates align with design system.The changes from
bg-surface-2tobg-layer-1for the kanban group container and the removal ofbg-surface-2from the header correctly follow the background layering guidelines. Kanban groups are nested content that should use layer backgrounds rather than surface backgrounds.Based on learnings, headers and content within the same container should share the same surface background with semantic borders for separation, rather than using separate surface backgrounds.
apps/web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx (2)
75-75: LGTM! Correct page-level background styling.The change from
bg-layer-1tobg-surface-1for the analytics page header is correct. Page-level containers should use surface backgrounds rather than layer backgrounds.Based on learnings, pages and routes should use
bg-surface-1(or appropriate surface variant) as their root container.
78-95: Tabs styling updates align with new variant system.The removal of the
backgroundprop and addition of explicit className for the Tabs.List, along with the height adjustment for Tabs.Trigger, aligns with the new variant-based styling system introduced in packages/propel/src/tabs/tabs.tsx.packages/propel/src/tabs/tabs.tsx (4)
5-11: LGTM! TabsContext pattern for variant propagation.The introduction of
TabsVarianttype andTabsContextprovides a clean way to propagate the variant through the component tree. The context pattern is appropriate for this use case.
36-49: LGTM! TabsRoot correctly provides variant context.The TabsRoot component properly wraps the primitive with the TabsContext.Provider, making the variant available to child components. The className construction is clean and maintainable.
51-75: LGTM! TabsList background handling updated correctly.The background prop has been simplified to use the
TabsVarianttype, defaulting to "contained". The conditional className application forbg-layer-3when background is "contained" is straightforward.
77-104: LGTM! TabsTrigger styling uses appropriate state variants.The TabsTrigger styling correctly uses
data-[selected]state variants withbg-layer-2for the selected state, which aligns with the design system guidelines. The use of-selectedvariants is appropriate here since the actual selection logic is implemented via thedata-[selected]attribute.Based on learnings, use
-selectedstate variants only when there is actual selection logic implemented, or use data attributes likedata-[selected]:bg-layer-1-selected.packages/propel/src/icon-button/helper.tsx (1)
41-41: LGTM! IconButton API extended for icon-specific styling.The addition of the optional
iconClassNameprop enables consumers to apply styling directly to the icon element independently from the button container. This provides greater styling flexibility, as demonstrated in the workspace sidebar components where it's used for icon rotation transitions.apps/web/core/components/workspace/sidebar/projects-list-item.tsx (1)
439-456: LGTM! Clean separation of button and icon styling.The use of the new
iconClassNameprop to control the chevron rotation is a cleaner approach than embedding transition-related classes in the button's className. This maintains the existing behavior while improving the styling organization.apps/web/core/components/workspace/sidebar/projects-list.tsx (1)
182-213: LGTM! Consistent migration to IconButton components.The replacement of native button elements with IconButton components provides a more consistent UI. The use of
iconClassNamefor the chevron rotation, along with preserved aria-labels and data attributes, maintains both functionality and accessibility.apps/web/core/components/analytics/select/project.tsx (1)
45-60: LGTM! Improved select trigger styling with button helpers.The migration from the
labelprop to acustomButtonwithgetButtonStylingand dedicated icon rendering provides more consistent styling across the application. The use of styling helpers ensures the select trigger aligns with the broader button design system.apps/web/core/components/base-layouts/layout-switcher.tsx (1)
26-26: Verify background layer is appropriate for parent container context.The container background changed from
bg-layer-1tobg-layer-3. Per the design guidelines, layers must match their parent surface: usebg-layer-1withinbg-surface-1,bg-layer-2withinbg-surface-2, andbg-layer-3withinbg-surface-3. Since this is a reusable component with varying parent contexts, ensure the parent container usesbg-surface-3, or adjust the layer to match the actual parent surface.packages/propel/src/icon-button/icon-button.tsx (1)
18-18: LGTM! Clean prop addition.The
iconClassNameprop with a safe default empty string follows the component's established pattern and enables icon-specific styling customization.
| const Icon = layout.icon; | ||
| return ( | ||
| <Tooltip key={layout.key} tooltipContent={layout.label} isMobile={isMobile}> | ||
| <Tooltip key={layout.key} tooltipContent={t(layout.i18n_title)} isMobile={isMobile}> |
Contributor
There was a problem hiding this comment.
Fix TypeScript compilation error.
The pipeline failure indicates that i18n_title does not exist on type IBaseLayoutConfig. This is a critical issue that breaks the build.
🔎 Verify the correct property name:
#!/bin/bash
# Search for IBaseLayoutConfig type definition and available properties
ast-grep --pattern $'interface IBaseLayoutConfig {
$$$
}'
# Search for BASE_LAYOUTS constant definition
ast-grep --pattern $'BASE_LAYOUTS = $$$'🧰 Tools
🪛 GitHub Actions: Build and lint web apps
[error] 30-30: TS2339: Property 'i18n_title' does not exist on type 'IBaseLayoutConfig'.
🤖 Prompt for AI Agents
In apps/web/core/components/base-layouts/layout-switcher.tsx around line 30, the
code references layout.i18n_title which doesn't exist on IBaseLayoutConfig; open
the IBaseLayoutConfig definition and the BASE_LAYOUTS constant to determine the
correct property name (e.g., i18nTitle, title, or key) and replace
layout.i18n_title with that property; if the property can be undefined, provide
a safe fallback like layout.title || layout.key (or a localized default) and
keep the access type-safe (narrow or cast) so TypeScript compiles cleanly.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/core/components/base-layouts/layout-switcher.tsx (1)
42-48: Icon styling updated correctly.The explicit
widthandheightprops (14px) and the conditional color classes are correctly applied. Note that thesize-3.5class in the className also sets dimensions to 14px, making the explicit props somewhat redundant, but this doesn't cause issues.🔎 Optional: Remove redundant size props
Since
size-3.5already sets the icon to 14×14px, you could remove the explicitwidthandheightprops:<Icon - width={14} - height={14} strokeWidth={2} className={cn("size-3.5", {However, keeping both provides explicit documentation and works fine if the icon component expects these props.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/core/components/base-layouts/layout-switcher.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}
📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
**/*.{ts,tsx,mts,cts}: Useconsttype parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfiesoperator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitisreturn types in filter/check functions
UseNoInfer<T>utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true)blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusingdeclarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" }for import attributes; avoid deprecatedassertsyntax (TypeScript 5.3/5.8+)
Useimport typeexplicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntaxflag
Use.ts,.mts,.ctsextensions inimport typestatements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" }for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSetmethods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy/Map.groupBystandard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers()for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuperin classes (TypeScript 5....
Files:
apps/web/core/components/base-layouts/layout-switcher.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Enable TypeScript strict mode and ensure all files are fully typed
Files:
apps/web/core/components/base-layouts/layout-switcher.tsx
**/*.{js,jsx,ts,tsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier with Tailwind plugin for code formatting, run
pnpm fix:format
Files:
apps/web/core/components/base-layouts/layout-switcher.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately
Files:
apps/web/core/components/base-layouts/layout-switcher.tsx
🧠 Learnings (8)
📚 Learning: 2025-12-17T10:58:59.591Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: packages/tailwind-config/AGENTS.md:0-0
Timestamp: 2025-12-17T10:58:59.591Z
Learning: Applies to packages/tailwind-config/**/*.{ts,tsx} : Use `-selected` state variants (e.g., `bg-layer-1-selected`) only when there is actual selection logic implemented, or use data attributes like `data-[selected]:bg-layer-1-selected`
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-12-12T15:20:36.542Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-12T15:20:36.542Z
Learning: Applies to packages/plane/ui/**/*.{ts,tsx} : Build components in `plane/ui` package with Storybook for isolated development
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-10-21T17:22:05.204Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7989
File: apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx:45-46
Timestamp: 2025-10-21T17:22:05.204Z
Learning: In the makeplane/plane repository, the refactor from useParams() to params prop is specifically scoped to page.tsx and layout.tsx files in apps/web/app (Next.js App Router pattern). Other components (hooks, regular client components, utilities) should continue using the useParams() hook as that is the correct pattern for non-route components.
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Ensure variables are initialized before use to avoid errors with never-initialized variables (TypeScript 5.7+)
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-10-09T20:42:31.843Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-10-01T15:30:17.605Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7888
File: packages/propel/src/avatar/avatar.stories.tsx:2-3
Timestamp: 2025-10-01T15:30:17.605Z
Learning: In the makeplane/plane repository, avoid suggesting inline type imports (e.g., `import { Avatar, type TAvatarSize }`) due to bundler compatibility issues. Keep type imports and value imports as separate statements.
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-10-09T22:12:26.424Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T22:12:26.424Z
Learning: When `types/react` is installed in a TypeScript project (which is standard for React + TypeScript codebases), React types (React.FC, React.ReactNode, React.ComponentProps, etc.) are globally available by design. These type annotations can and should be used without explicitly importing the React namespace. This is a TypeScript/DefinitelyTyped feature, not codebase-specific configuration.
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
📚 Learning: 2025-03-11T19:42:41.769Z
Learnt from: janreges
Repo: makeplane/plane PR: 6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
Applied to files:
apps/web/core/components/base-layouts/layout-switcher.tsx
🧬 Code graph analysis (1)
apps/web/core/components/base-layouts/layout-switcher.tsx (3)
packages/i18n/src/hooks/use-translation.ts (1)
useTranslation(23-35)apps/web/core/components/base-layouts/constants.ts (1)
BASE_LAYOUTS(4-20)packages/i18n/src/store/index.ts (1)
t(222-243)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Build packages
🔇 Additional comments (4)
apps/web/core/components/base-layouts/layout-switcher.tsx (4)
1-1: LGTM: Imports added correctly.The
useTranslationandcnimports are properly structured and both are utilized in the component.Also applies to: 4-4
17-17: LGTM: useTranslation hook integrated correctly.The hook is properly initialized and the
tfunction is correctly destructured.
26-26: LGTM: Container styling updated appropriately.The styling changes (border radius, background layer, padding) align with the PR's refactoring objectives and improve the visual presentation.
33-38: LGTM: Button styling refactored properly.The
cnutility is correctly used to apply conditional classes based on the selected layout state. The active state styling appropriately uses-activevariants rather than-selectedvariants (as per learnings about state variant usage).
| const Icon = layout.icon; | ||
| return ( | ||
| <Tooltip key={layout.key} tooltipContent={layout.label} isMobile={isMobile}> | ||
| <Tooltip key={layout.key} tooltipContent={t(layout.label)} isMobile={isMobile}> |
Contributor
There was a problem hiding this comment.
Critical: Handle missing label for gantt layout.
From the BASE_LAYOUTS constant, the gantt layout doesn't have a label property, which means layout.label is undefined for that layout. Passing undefined to t(key: string) violates the type signature and causes a TypeScript compilation error (similar to the previous i18n_title issue flagged in past reviews).
This is a blocking issue that prevents the build from passing.
🔎 Apply this diff to add a fallback:
- <Tooltip key={layout.key} tooltipContent={t(layout.label)} isMobile={isMobile}>
+ <Tooltip key={layout.key} tooltipContent={t(layout.label || layout.key)} isMobile={isMobile}>Alternative solution: Add a label property to the gantt layout in BASE_LAYOUTS constant:
{
key: "gantt",
icon: TimelineLayoutIcon,
label: "Timeline Layout", // Add this
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <Tooltip key={layout.key} tooltipContent={t(layout.label)} isMobile={isMobile}> | |
| <Tooltip key={layout.key} tooltipContent={t(layout.label || layout.key)} isMobile={isMobile}> |
🤖 Prompt for AI Agents
In apps/web/core/components/base-layouts/layout-switcher.tsx around line 30,
layout.label can be undefined for the "gantt" layout which causes
t(layout.label) to violate the i18n function signature; update the call to pass
a guaranteed string by using a fallback (e.g., t(layout.label ?? layout.key) or
t(layout.label || 'gantt') ), or alternatively add a label property to the gantt
entry in BASE_LAYOUTS so layout.label is always defined.
anmolsinghbhatia
approved these changes
Dec 18, 2025
KooshaPari
added a commit
to KooshaPari/Planify
that referenced
this pull request
Mar 29, 2026
) * [PAI-963] feat: enhance CustomSelect component with context for dropdown management (makeplane#8202) * feat: enhance CustomSelect component with context for dropdown management * refactor: streamline CustomSelect component structure and improve dropdown options rendering * [WEB-5603] feat: enhance workspace settings layout and members page (makeplane#8266) * feat: enhance workspace settings layout and members page with new components * refactor: update workspace settings layout and members page to use default exports * refactor: settings layout import changes * refactor: simplify workspaceSlug usage in settings layout * [WEB-5592] chore: add static files update settings for static files support (makeplane#8251) * chore: add static files collection and update settings for static files support * chore: add WhiteNoise middleware for static file handling * chore(deps): upgrade WhiteNoise to version 6.11.0 and add static file reverse proxy in Caddyfile * [WEB-5256]chore: quick actions refactor (makeplane#8019) * chore: quick actions refactor * chore: lint fix * chore: unified factory for actions * chore: lint fix * * chore: removed redundant files * chore: updated imports * chore: updated interfaces to types * chore: updated undefined handling * [WIKI-829] fix: add option to only show placeholder on empty editor (makeplane#8232) * feat: add placeholderOnEmpty functionality to editor components * Update packages/editor/src/core/extensions/placeholder.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: rename placeholderOnEmpty to showPlaceholderOnEmpty across editor components * chore : make optional --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIKI-830] fix: copy clipboard functionality in the editor (makeplane#8229) * feat: enhance clipboard functionality for markdown and HTML content * fix: improve error handling and state management in CustomImageNodeView component * fix: correct asset retrieval query by removing workspace filter in DuplicateAssetEndpoint * fix: update meta tag creation in PasteAssetPlugin for clipboard HTML content * feat: implement copyMarkdownToClipboard utility for enhanced clipboard functionality * refactor: replace copyMarkdownToClipboard utility with copyTextToClipboard for simplified clipboard operations * refactor: streamline clipboard operations by replacing copyTextToClipboard with copyMarkdownToClipboard in editor components * refactor: simplify PasteAssetPlugin by removing unnecessary meta tag handling and streamlining HTML processing * feat: implement asset duplication processing on paste for enhanced clipboard functionality * chore:remove async from copy markdown method * chore: add paste html * remove:prevent default * refactor: remove hasChanges from processAssetDuplication return type for simplified asset processing * fix: format options-dropdown.tsx * feat: add timezone selection to workspace settings (makeplane#8248) * feat: add timezone selection to workspace onboarding, creation and settings * refactor: remove timezone selection from workspace creation and onboarding forms * [WEB-5285] feat: enhance ChangeTrackerMixin to capture changed fields on save (makeplane#8270) - Added an override for the save method in ChangeTrackerMixin to store changed fields before resetting tracking. - Implemented a new method, _reset_tracked_fields, to ensure subsequent saves detect changes relative to the last saved state. - Updated IssueComment to utilize _changes_on_save for determining changed fields, improving accuracy in tracking modifications. * [WEB-5585]chore: timeline chart refactor (makeplane#8246) * chore: timeline chart refactor * fix: format * [WEB-5575]feat: enhance APITokenLogMiddleware to support logging to MongoDB (makeplane#8241) * feat: enhance APITokenLogMiddleware to support logging to MongoDB - Added functionality to log external API requests to MongoDB, with a fallback to PostgreSQL if MongoDB is unavailable. - Implemented error handling for MongoDB connection and logging operations. - Introduced additional fields for MongoDB logs, including timestamps and user identifiers. - Refactored request logging logic to streamline the process and improve maintainability. * fix: improve MongoDB availability checks in APITokenLogMiddleware - Enhanced the logic for determining MongoDB availability by checking if the collection is not None. - Added a check for MongoDB configuration before attempting to retrieve the collection. - Updated error handling to ensure the middleware correctly reflects the state of MongoDB connectivity. * feat: implement logging functionality in logger_task for API activity - Added a new logger_task module to handle logging of API activity to MongoDB and PostgreSQL. - Introduced functions for safely decoding request/response bodies and processing logs based on MongoDB availability. - Refactored APITokenLogMiddleware to utilize the new logging functions, improving code organization and maintainability. * refactor: simplify MongoDB logging in logger_task and middleware - Removed direct dependency on MongoDB collection in log_to_mongo function, now retrieving it internally. - Updated process_logs to check MongoDB configuration before logging, enhancing error handling. - Cleaned up logger.py by removing unused imports related to MongoDB. * feat: add Celery task decorator to process_logs function in logger_task - Introduced the @shared_task decorator to the process_logs function, enabling asynchronous processing of log data. - Updated function signature to include a return type of None for clarity. * [WEB-5609] fix: extended sidebar item pin/unpin makeplane#8287 * [WEB-5608] chore: Hide "Pro" Features in Community Edition (makeplane#8288) * chore: Hide "Pro" Features in Community Edition * refactor: remove time tracking feature and simplify project features list * chore: moving star us button to the top navigation (makeplane#8289) * chore: optimize turborepo (makeplane#8286) * [WIKI-844] fix: realtime sync post vite migration with title editor sync and indexed db access (makeplane#8294) * fix: robust way to handle socket connection and read from indexeddb cache when reqd * fix: realtime sync working with failure handling * fix: title editor added * merge preview into fix/realtime-sync * check * page renderer props * lint errors * lint errors * lint errors * sanitize html * sanitize html * format fix * fix lint * [WEB-4440] fix: duplicate sequence when creating multiple workitems in rapid succession (makeplane#8298) - Replace advisory lock with transaction-level lock in Issue model save method - Updated the save method in the Issue model to use a transaction-level advisory lock for better concurrency control. - Simplified the locking mechanism by removing the explicit unlock step, as the lock is automatically released at the end of the transaction. - Maintained existing functionality for sequence and sort order management while improving code clarity. * chore: format files in API server (makeplane#8292) * chore: fix ruff checks (makeplane#8305) * fix: editor sync changes (makeplane#8306) * chore: upate function declarations * chore: formatted files * chore: fix/check tooling improvements with turbo (makeplane#8304) * fix: broken lock file * chore: add Plane sync label to github templates makeplane#8303 Co-authored-by: Pushya Mitra Thiruvooru <pushya@Pushyas-MacBook-Pro.local> * [WEB-5624] chore: added webhook translations makeplane#8312 * chore(deps): upgrade next themes package * [WEB-5654]fix: custom select selection and dropdown close makeplane#8324 * [WEB-5124] chore: intake work item toast enhancements (makeplane#8329) * [WEB-5647] chore: list layout work item identifier enhancements (makeplane#8326) * chore: file formating * [WEB-5650] feat: Enable Gitea OAuth configuration (makeplane#8325) * feat: implement OAuth configuration helper and integrate into auth forms * fix: ensure OAuth providers are disabled by default if not configured * [WEB-5602] feat: new design system (makeplane#8220) * chore: init tailwind v4 * chore: update all configs * chore: add source to parse monorepo packages * chore: combine all css files * feat: added extended colors * chore: update typography * chore: update extended color var names * refactor: remove initial spacing variable and update dark mode selector * chore: update css files * chore: update animations * chore: remove spacing tokens * fix: external css files * chore: update tailwind-merge version * chore: update font family * chore: added brief agents.md and story for new design system * chore: enhance design system documentation with rare exceptions for visual separation * chore: add fontsource package for typography * chore: material symbols font added * chore: update shadow default * chore: add stroke and outline theme vars * chore: update ring and fill colors * chore: overwrite tailwind typography tokens * chore: add high contrast mode tokens * chore: update scrollbar colors * chore: backward compatibility for buttons and placeholders * chore: add priority colors * chore: update urgent priority color * chore: update plan colors * chore: add missing utility class * chore: update height and padding classes * chore: update label colors * chore: add missing utlity * chore: add typography plugin to space app * chore: replace existing classNames with new design system tokens makeplane#8244 (makeplane#8278) * chore: update border colors * chore: update all borders * chore: update text colors * chore: update css variables * chore: update font sizes and weights * chore: update bg colors * chore: sync changes * fix: uncomment spacing-1200 variable in variables.css * chore: update primary colors * refactor: updated border to border-subtle * refactor: update various components and improve UI consistency across the application * updated classnames * updated classnames * refactor: update color-related class names to use new design system variables for consistency * chore: default automations * chore: update text sizes * chore: home and power k * chore: home and power k * chore: replace ui package button components * chore: update text sizes * chore: updated issue identifier (makeplane#8275) * refactor: top navigation and sidebar design token (makeplane#8276) * chore: update all button components (makeplane#8277) * chore: new button component * chore: update existing buttons * chore: overwrite tailwind typography tokens * fix: twMerge config + fixed cn instances * refactor: toast design token updated (makeplane#8279) * chore: update existing buttons * chore: tooltip design token updatged (makeplane#8280) * chore: moved cn utility to propel (makeplane#8281) * chore: update space app UI (makeplane#8285) * chore; update space app filters component * fix: button whitespace wrap * chore: space app votes * chore: update dropdown components * refactor: auth, onboarding, sidebar, and common component design token migration (makeplane#8291) * chore: checkbox component design token updated * chore: indicator and oauth component design token updated * chore: sidebar design token updated * chore: auth and onboarding design token updated * chore: update divider color * style: update background colors and hover effects across list components * fix: tailwind merge * refactor: toggle switch design token migration and header utility classname added (makeplane#8295) * chore: toggle component design token updated * chore: h-header utility class added * chore: updated color tokens for work item detail page (makeplane#8296) * chore: update react-day-picker UI * refactor: update button sizes and styles in filters components * refactor: breadcrumbs design token updated (makeplane#8297) * chore: update priority icon colors * refactor: updated layout variables * chore: update plan card primary CTA * Chore update editor design system (makeplane#8299) * refactor: update styles for callout, color selector, logo selector, and image uploader * refactor:fix image * chore: update settings UI * chore: updated notifications color and size tokens (makeplane#8302) * chore: update sm button border radius * fix: logo renderer * chore: icon button component * chore: remove deprecated classes * chore: remove deprecated classes * chore: update editor list spacing * fix: icon button size * chore: improvements (makeplane#8309) * chore: update cycles and modules pages * refactor: update background styles across various components to use new design system colors * fix: button type errors * chore: update modals design system (makeplane#8310) * refactor: callout bg * refactor: code bg * refactor: modal size and variant --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * chore: update next-themes * design: update billing and plans component styles and remove unused utility functions (makeplane#8313) * refactor: empty state design token migration and improvements (makeplane#8315) * fix: profile page * refactor: tabs design token updated (makeplane#8316) * chore: updated buttons and tokens for work items (makeplane#8317) * fix: adjust trial button spacing in checkout modal * chore: update add button hover state * fix: type error (makeplane#8318) * fix: type error * chore: code refactor * refactor: update button sizes and background styles in rich filters components * refactor: update editor bg * refactor: enhance Gantt chart sidebar functionality and styling - Removed unused prop from . - Updated to include new props for better block management and scrolling behavior. - Improved auto-scroll functionality for Gantt chart items. - Adjusted styles in component for consistent design. * regression: gantt design * chore: new badge component * fix: favorite star * chore: update backgroung, typography and button sizes across workspace settings general and members pages * fix: header button sizes * fix: emoji icon logo (makeplane#8323) * more fixes * chore: update settings sidebar * refactor: avatar component * chore: updated work item detail sidebar (makeplane#8327) * refactor: update link preview * fix: work item property dropdowns * fix: dropdown buttons border radius * chore: update power k translation * chore: updated profile activity design (makeplane#8328) * chore: update settings pages * chore: update work item sidebar alignments (makeplane#8330) * refactor: admin design system * chore: update page header --------- Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: VipinDevelops <vipinchaudhary1809@gmail.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> * fix: formatting * reexport types * fix: lint error --------- Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: VipinDevelops <vipinchaudhary1809@gmail.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> * [WEB-5668] fix: add fetchWorkspaceLevelProjectEntities method and update project-related fetch keys (makeplane#8347) * [SILO-783] feat: added porters and new serializer based exporter (makeplane#8335) * [WEB-5699] refactor: update styling and classnames of charts according to new design system (makeplane#8345) * refactor: update styling and class names according to new design system in charts * refactor: clean up * feat: custom theming enhancements (makeplane#8342) * [WEB-5671] chore: settings workspace members enhancements makeplane#8346 * [WEB-5666] chore: set project timezone same as workspace timezone in project (makeplane#8340) * [WEB-5614] fix: new design system consistency (makeplane#8351) * chore: tooltip enhancements * chore: project card enhancements * chore: work item card enhancements * chore: update component styles and class names for consistency across the application --------- Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WEB-5708] regression: remove material icon instances from the Space app (makeplane#8353) * chore: sync changes (makeplane#8343) * [WEB-5614] chore: work item detail and list layout enhancements makeplane#8355 * regression: replace old css vars with the new design system tokens (makeplane#8354) * chore: replace old css vars * fix: replace shadow and primary colors * chore: remove hardcoded colors * [WEB-5614] chore: custom theme on colour improvement makeplane#8356 * [WEB-5732] style: update work item detail properties UI (makeplane#8357) * [WEB-5730] fix: user mention colors makeplane#8358 * [WEB-5614] fix: empty state and padding token fixes (makeplane#8359) * [WEB-5614] chore: update component styles and class names for consistency across projects makeplane#8360 * [WEB-5614] chore: logo and icon enhancements makeplane#8362 * fix: work item property icon renderer (makeplane#8363) * [WEB-5614] fix: sidebar and label dropdown makeplane#8364 * fix: material icons font file (makeplane#8366) * [WEB-5614] chore: lucide icon code refactor makeplane#8365 * fix: nested context menu UI (makeplane#8367) * [WEB-5708] style: space app kanban card UI (makeplane#8368) * [WEB-5742] fix: input field background makeplane#8369 * [WEB-5641] chore: sub work item quick menu padding makeplane#8370 * chore: replace old classNames (makeplane#8372) * chore: update component styles and class names for consistency across the application (makeplane#8376) * [WEB-5660] [WEB-5737] fix: cycle and module sidebar makeplane#8375 * [WEB-5676] style: gantt column outline makeplane#8374 * [WEB-5614] chore: platform design token enhancements (makeplane#8373) * [WEB-5649] [WEB-5675] fix: local font files makeplane#8377 * [WEB-5614] chore: primitive token updated (makeplane#8378) * fix: tooltip imports (makeplane#8379) * [WEB-5614] chore: platform header and breadcrumb enhancements (makeplane#8383) * [WEB-5652] fix: kanban quick add UI makeplane#8382 * [WEB-5726] fix: showing an empty state on deleted work item link makeplane#8381 * fix: space app default background (makeplane#8384) * [WIKI-849] feat: debounce for mention search (makeplane#8380) * fix: font imports (makeplane#8387) * chore: platform layout enhancements (makeplane#8386) * fix: image uploader bg in light mode (makeplane#8385) * [WEB-5614] refactor: update styling and structure across various components (makeplane#8388) * fix: input fields bg (makeplane#8389) * fix: custom z-index classNames (makeplane#8395) * [WEB-5454] fix: optimize date validation logic in CycleCreateUpdateModal makeplane#8394 * [WEB-5614] chore: work item detail comment and sidebar enhancements (makeplane#8397) * [WEB-5675] chore: implement `fontsource` as the fonts library (makeplane#8398) * [WEB-5762] fix: workitem detail sidebar properties design consistency (makeplane#8400) * [WEB-5761]fix: intake spacing issue (makeplane#8399) * [WEB-5614] chore: sidebar enhancement makeplane#8401 * [WEB-5768]chore: updated comment UI makeplane#8402 * [WEB-5614] chore: package and layout enhancements makeplane#8403 * chore: update storybook dependency * [WEB-5657] feat: add synchronization configuration for multiple providers in authentication adapter (makeplane#8336) * feat: add sync functionality for OAuth providers - Implemented `check_sync_enabled` method to verify if sync is enabled for Google, GitHub, GitLab, and Gitea. - Added `sync_user_data` method to update user details, including first name, last name, display name, and avatar. - Updated configuration variables to include sync options for each provider. - Integrated sync check into the login/signup process. * feat: add sync toggle for OAuth providers in configuration forms * fix: remove default value for sync options in OAuth configuration forms * chore: delete old avatar and upload a new one * chore: update class method * chore: add email nullable * refactor: streamline sync check for multiple providers and improve avatar deletion logic * fix: ensure ENABLE_SYNC configurations default to "0" for Gitea, Github, Gitlab, and Google forms * fix: simplify toggle switch value handling in ControllerSwitch component --------- Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> * [WEB-5657] chore: synchronization configuration for multiple providers in authentication adapter makeplane#8409 * [WEB-5746]fix: workspace member modal z-index makeplane#8410 * [WEB-5773] fix: editor image full screen modal (makeplane#8413) * [WEB-5774] fix: editor nodes background colors (makeplane#8416) * [WEB-5776]chore: updated design system for alert modal makeplane#8415 * [WEB-5775] fix: mentions search on empty query makeplane#8417 * [WEB-5662][WEB-5770] fix: alignment of cycles in sidebar and layout selection dropdown button (makeplane#8414) * fix: alpha colors (makeplane#8418) * [WEB-5784] fix: truncation issue in wi properties (makeplane#8422) * fix: update background surface 2 variables in tailwind config * fix: improve layout and truncation handling in issue link and list items * docs: update readme with react router badge (makeplane#8424) Updated feature list and modified the local development section. * [WEB-5788] fix: board layout group by icon makeplane#8426 * [WEB-5792] regression: editor font family makeplane#8427 * [WIKI-740] refactor: editor table performance (makeplane#8411) * [WEB-5786] fix: updated font size for dates at Kanban card makeplane#8429 * [WEB-5772] fix: theme switch flicker (makeplane#8428) * [WEB-5784] fix: truncation of links in work items (makeplane#8430) * [WEB-5772] chore: theme switcher and editor colors enhancements (makeplane#8436) * [WEB-5772] chore: theme switcher code refactor makeplane#8438 * chore: workspace events (makeplane#8439) * chore: adding invite and joined events * chore: adding workspace create and update events * [WEB-5798] refactor: web and admin auth related components and update admin designs (makeplane#8431) * refactor: web and admin auth related components and update admin designs. * fix: format * [WEB-5581] fix: resolve logo spinner hydration and theme loading issues (makeplane#8450) - Fix hydration mismatch by lazy loading components that depend on theme - Ensure LogoSpinner renders with correct theme on initial load * [WEB-5791] fix: broken favicon in links (makeplane#8396) * fix: using base url of a redirect url * chore: internal networks check for the final_url * fix: none final_url * fix: exception handling * fix: exception handling * chore: remove unused imports * refactor: moved ip address check logic into separate function * fix: ValueError logic * [WEB-5667] fix: estimate value display in analytics makeplane#8448 * [WEB-5779] fix: handle loading state while fetching project cover image (makeplane#8419) * refactor: replace cover image handling with CoverImage component across profile and project forms * fix: extend CoverImage component to accept additional img props * Update apps/web/core/components/common/cover-image.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: handle undefined cover image URL in ProfileSidebar component --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WEB-5782]chore: migrated modals to @plane/ui (makeplane#8420) * chore: migrated modal to @plane/ui * chore: fixed spacings * [WEB-5808] chore: sidebar project list enhancements (makeplane#8451) * chore: sidebar project list enhancements * chore: code refactor * chore: code refactor * [WEB-5324] refactor: add Unified OAuth Configuration and Missing Gitea Options (makeplane#8050) * refactor: add Unified OAuth Configuration and Missing Gitea Options - Replaced the AuthenticationModes component with a more streamlined implementation using AuthenticationMethodCard. - Removed obsolete authentication modes files from the codebase. - Enhanced the AuthRoot component to utilize the new OAuth configuration hook for better management of authentication options. - Updated type definitions for instance authentication modes to reflect the new structure. * refactor: update OAuth type imports and remove obsolete types - Replaced local type imports with centralized imports from @plane/types in core, extended, and index OAuth hooks. - Removed the now redundant types.ts file as its definitions have been migrated. - Enhanced type definitions for OAuth options to improve consistency across the application. * feat: add new Gitea logo and update OAuth icon imports to use standard HTML img tags * chore: remove unused authentication logos and upgrade button component * [WEB-5574]chore: notification card refactor (makeplane#8234) * chore: notification card refactor * chore: moved base activity types to constants package * [WEB-5804] refactor: decouple filter value types from filter configurations (makeplane#8441) * [WEB-5804] refactor: decouple filter value types from filter configurations Remove value type constraints from filter configurations to support operator-specific value types. Different operators can accept different value types for the same filter property, so value types should be determined at the operator level rather than the filter level. - Remove generic value type parameter from TFilterConfig - Update TOperatorConfigMap to accept union of all value types - Simplify filter config factory signatures across all filter types - Add forceUpdate parameter to updateConditionValue method * refactor: remove filter value type constraints from filter configurations Eliminate the generic value type parameter from filter configurations to allow for operator-specific value types. This change enhances flexibility by enabling different operators to accept various value types for the same filter property. - Updated TFilterConfig and related interfaces to remove value type constraints - Adjusted filter configuration methods and types accordingly - Refactored date operator support to align with the new structure * [WEB-5785]fix: favorites icon size makeplane#8449 * [WEB-5781]chore: removed info banner for preferences makeplane#8442 * [WEB-5809] refactor: tailwind config inline variables (makeplane#8437) * refactor: actions icon migration (makeplane#8219) * chore: gitignore updated * chore: check icon added to propel package * feat: search icon migration * chore: check icon migration * chore: plus icon added to propel package * chore: code refactor * chore: plus icon migration and code refactor * chore: trash icon added to propel package * chore: code refactor * chore: trash icon migration * chore: edit icon added to propel package * chore: new tab icon added to propel package * chore: edit icon migration * chore: newtab icon migration * chore: lock icon added to propel package * chore: lock icon migration * chore: globe icon added to propel package * chore: globe icon migration * chore: copy icon added to propel package * chore: copy icon migration * chore: link icon added to propel package * chore: link icon migration * chore: link icon migration * chore: info icon added to propel package * chore: code refactor * chore: code refactor * chore: code refactor * chore: code refactor * regression: red and green color backgrounds (makeplane#8456) * [WEB-5815] chore: removed the deleted states (makeplane#8457) * Typo: database extension error message (makeplane#8461) * [WEB-5179] chore: icon utils code refactor makeplane#8458 * [WEB-5790] feat: new email templates (makeplane#8423) * chore: remove unused get_client_ip import (makeplane#8453) Remove unused import `get_client_ip` from workspace/invite.py. Identified by ruff linter (F401 error). Signed-off-by: majiayu000 <1835304752@qq.com> * [WEB-5822] fix: migrate ImagePickerPopover to Propel Tabs component and render only enabled tabs makeplane#8290 - Replace custom tab implementation with Propel Tabs - Dynamically render only enabled tabs based on configuration - Filter tabs by isEnabled property for cleaner conditional rendering - Improve tab navigation and accessibility with Propel components * chore: navigation preference enhancements (makeplane#8468) * [WEB-5472] refactor: components of project creation flow (makeplane#8462) * [WEB-857] regression: image uploader error state makeplane#8471 * [WEB-4959]chore: refactor project member page makeplane#8464 * [WEB-5472] refactor: project form makeplane#8472 * migration: added webhook version, navigation related fields and allowed_rate_limit for APIToken (makeplane#8339) * migration: added version field in webhook * chore: add max_length * chore: added product tour fields * chore: updated the migration file * chore: removed the duplicated migration file * chore: added allowed_rate_limit for api_tokens * chore: changed key feature tour to product tour * chore: added is_subscribed_to_changelog field --------- Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> * fix: correct spelling error in database.ts log message (makeplane#8452) Fix "convertion" -> "conversion" in error log message. Signed-off-by: majiayu000 <1835304752@qq.com> * [WEB-5598] refactor: streamline object creation in workspace seed task and improve error handling in workspace creation makeplane#8264 * chore: remove posthog events (makeplane#8465) * chore: remove posthog events * chore: remove event tracking * chore: lint errors * chore: minor changes based on comments * fix: type errors * Revert "[WEB-4959]chore: refactor project member page makeplane#8464" (makeplane#8476) This reverts commit c97e418. * chore: remove unused right sidebar component and clean up workspace member settings (makeplane#8477) * [WEB-5537]refactor: rename IssueUserProperty to ProjectUserProperty and update related references (makeplane#8206) * refactor: rename IssueUserProperty to ProjectUserProperty and update related references across the codebase * migrate: move issue user properties to project user properties and update related fields and constraints * refactor: rename IssueUserPropertySerializer and IssueUserDisplayPropertyEndpoint to ProjectUserPropertySerializer and ProjectUserDisplayPropertyEndpoint, updating all related references * fix: enhance ProjectUserDisplayPropertyEndpoint to handle missing properties by creating new entries and improve response handling * fix: correct formatting in migration for ProjectUserProperty model options * migrate: add migration to update existing non-service API tokens to remove workspace association * migrate: refine migration to update existing non-service API tokens by excluding bot users from workspace removal * chore: changed the project sort order in project user property * chore: remove allowed_rate_limit from APIToken * chore: updated user-properties endpoint for frontend * chore: removed the extra projectuserproperty * chore: updated the migration file * chore: code refactor * fix: type error --------- Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> Co-authored-by: sangeethailango <sangeethailango21@gmail.com> Co-authored-by: vamsikrishnamathala <matalav55@gmail.com> Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WIKI-826] chore: add unique id as key to logo selector (makeplane#8494) * [VPAT-50] chore(security): add X-Frame-Options header to nginx configuration to prevent clickjacking attacks (makeplane#8507) * [VPAT-50] chore(security): add X-Frame-Options header to nginx configuration to prevent clickjacking attacks * [SECURITY] chore: enhance nginx configuration with additional security headers * chore: updated migration file name (makeplane#8515) * chore(deps): react router upgraded * [WEB-5890] migration: added getting_started_checklist, tips, explored_feature fields on the workspace member table (makeplane#8489) * migration: added getting_started_checklist and tips field * fix: remove defaults and added explored_features field * fix: added user table migration * [WEB-5907] fix: magic code sign-in at Space app. makeplane#8552 * [WIKI-735] fix: table insert handle z-index makeplane#8545 * [WEB-5898] chore: update tailwind config makeplane#8516 * chore(deps): bump lodash-es in the npm_and_yarn group across 1 directory (makeplane#8573) Bumps the npm_and_yarn group with 1 update in the / directory: [lodash-es](https://github.com/lodash/lodash). Updates `lodash-es` from 4.17.21 to 4.17.23 - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.17.23 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [WEB-5845] chore: changing description field to description json (makeplane#8230) * chore: migrating description to description json * chore: replace description with description_json * chore: updated migration file * chore: updated the migration file * chore: added description key in external endpoint * chore: updated the migration file * chore: updated the typo --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * chore: fix typos in comments (makeplane#8553) * [GIT-61] chore: allow .md files to be uploaded (makeplane#8571) * chore: allow .md files to be uploaded * chore: allow .md files to be uploaded * [WEB-5860] [WEB-5861] [WEB-5862] style: improved settings interface (makeplane#8520) * style: improved profile settings * chore: minor improvements * style: improved workspace settings * style: workspace settings content * style: improved project settings * fix: project settings flat map * chore: add back navigation from settings pages * style: settings content * style: estimates list * refactor: remove old code * refactor: removed unnecessary line breaks * refactor: create a common component for page header * chore: add fade-in animation to sidebar * fix: formatting * fix: project settings sidebar header * fix: workspace settings sidebar header * fix: settings content wrapper scroll * chore: separate project settings features * fix: formatting * refactor: custom theme selector * refactor: settings headings * refactor: settings headings * fix: project settings sidebar padding * fix: sidebar header padding * fix: sidebar item permissions * fix: missing editable check * refactor: remove unused files * chore: remove unnecessary code * chore: add missing translations * fix: formatting * [GIT-45] fix: allow markdown file attachments (makeplane#8524) * fix: allow markdown file attachments - Add text/markdown to ATTACHMENT_MIME_TYPES - Fixes issue where .md files were rejected with 'Invalid file type' error * added the support for frontend mime type too * fix: node view renders (makeplane#8559) * fix node renders * fix handlers * fix: duplicate id * fix: pdf export (makeplane#8564) * feat: pdf export * fix: tests * fix: tests --------- Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * migration: back migrate all product tour fields to set true (makeplane#8575) * [GIT-66] improvement: prevent disabling last enabled authentication method (makeplane#8570) * fully translated into Ukrainian language (makeplane#8579) * chore: add copyright (makeplane#8584) * feat: adding new copyright info on all files * chore: adding CI * fix: module percentage calculation (makeplane#8595) * fix: file fomatting * [SECUR-113] fix: ssrf for work item links (makeplane#8607) * [SECUR-104] fix: Arbitrary Modification of API Token Rate Limits#8612 * chore(deps): upgrade django version * [WEB-6058] chore : add logic to handle save#8614 * chore(deps): update the node pacakges * fix: type fix for description payload (makeplane#8619) * fix: type fix * fix: duplicate type fix * chore(deps): update lodash package * [WEB-6149] migration: change estimate point key max value to 50 makeplane#8620 * fix: remove ee folder from web (makeplane#8622) * chore: merge constants and services (makeplane#8623) * fix: remove constants and services * fix: formatting * fix: types check * chore: merge helpers and layouts (makeplane#8624) * fix: remove constants and services * fix: formatting * chore: merge helpers and layouts * fix: workspace disbale flag handling * chore(deps): bump cryptography (makeplane#8625) Bumps the pip group with 1 update in the /apps/api/requirements directory: [cryptography](https://github.com/pyca/cryptography). Updates `cryptography` from 44.0.1 to 46.0.5 - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@44.0.1...46.0.5) --- updated-dependencies: - dependency-name: cryptography dependency-version: 46.0.5 dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: update ASCII art in install script header (makeplane#8628) * [WEB-6038] fix: work item empty title flicker makeplane#8618 * fix: workitem description input inital load (makeplane#8617) * [WEB-6137] fix: work item peek view outside click makeplane#8610 * [SECUR-105] fix: csv injection vulnerability sanitization makeplane#8611 * [WIKI-877] fix: order of this dropdown options in pages makeplane#8563 * [WEB-5899]fix: project sort order (makeplane#8530) * fix: project sort order * chore: updated queryset for sort_order * chore: admin folder structure (makeplane#8632) * chore: admin folder structure * fix: copy right check and formatting * fix: types * i18n(ru): expand Russian translation coverage (makeplane#8603) Added missing translations for: - Profile preferences (language, timezone settings) - Account settings sections (preferences, notifications, security, api-tokens, activity) - Workspace settings (billing, exports, webhooks headings/descriptions) - Project settings (states, labels, estimates, automations headings/descriptions) - Power-K command palette (contextual actions, navigation, creation, preferences, help) - Sidebar elements (stickies, your_work, pin/unpin) - Common actions (copy_markdown, overview) - Navigation customization options * chore(deps): update axios dependency * [GIT-57 | WEB-5912] fix: app sidebar ux and responsiveness (makeplane#8560) * fix: project extended sidebar accordion ux * fix: app sidebar mobile responsiveness ux * chore: code refactor * refactor: table drag preview using decorations (makeplane#8597) * refactor: table drag preview using decorations * fix: history meta for table drag state * [WEB-5884] chore: layout loader enhancements makeplane#8500 * [WEB-1201] chore: dropdown options hierarchy improvements (makeplane#8501) * chore: sortBySelectedFirst and sortByCurrentUserThenSelected utils added * chore: members dropdown updated * chore: module dropdown updated * chore: project and label dropdown updated * chore: code refactor * [GIT-44] refactor(auth): add PASSWORD_TOO_WEAK error code (makeplane#8522) * refactor(auth): add PASSWORD_TOO_WEAK error code and update related error handling in password change flow * fix(auth): update import to use type for EAuthenticationErrorCodes in security page * Update apps/web/app/(all)/profile/security/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: updated auth error exception accross zxcvbn usages * fix: improve error handling for password strength validation and update error messages * i18n(ru): update Russian translations for stickies and automation description Added translation for 'stickies' and improved formatting of the automation description in Russian locale. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update translations.ts: issue-artifacts discoverd (makeplane#7979) * [WEB-5873] fix: user avatar ui consistency (makeplane#8495) * fix: user avatar ui consistency * chore: code refactor * [SILO-820] fix: update serializer for module detail API endpoint to use ModuleUpdateSerializer (makeplane#8496) * [VPAT-51] fix: update workspace invitation flow to use token for validation makeplane#8508 - Modified the invite link to include a token for enhanced security. - Updated the WorkspaceJoinEndpoint to validate the token instead of the email. - Adjusted the workspace invitation task to generate links with the token. - Refactored the frontend to handle token in the invitation process. Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * [WEB-5871] chore: added intake count for projects (makeplane#8497) * chore: add intake_count in project list endpoint * chore: sidebar project navigation intake count added * fix: filter out closed intake issues in the count * chore: code refactor * chore: code refactor * fix: filter out deleted intake issues --------- Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> * [WEB-5829] fix: Intake open work count (makeplane#8547) * fix: open intake count at sidebar header * chore: reverted inbox store arguments to core store * fix: intake count update * [WEB-5863] fix: estimate point input validation makeplane#8492 Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> * [VPAT-55] chore(security): implement input validation across authentication and workspace forms (makeplane#8528) * chore(security): implement input validation across authentication and workspace forms - Add OWASP-compliant autocomplete attributes to all auth input fields - Create centralized validation utilities blocking injection-risk characters - Apply validation to names, display names, workspace names, and slugs - Block special characters: < > ' " % # { } [ ] * ^ ! - Secure sensitive input fields across admin, web, and space apps * chore: add missing workspace name validation to settings and admin forms * feat: enhance validation regex for international names and usernames - Updated regex patterns to support Unicode characters for person names, display names, company names, and slugs. - Improved validation functions to block injection-risk characters in names and slugs. * [VPAT-16] improvement: add file validation to prevent malicious uploads makeplane#8493 Add client-side checks for double extensions, dangerous file types, dot files, and path traversal patterns. Addresses security audit recommendations for file upload validation. * [WEB-5827] fix: persist external cover image URLs (Unsplash) in project updates makeplane#8482 * [VPAT-27] chore(security): disable autocomplete on sensitive input fields makeplane#8517 Disable autocomplete on authentication and security-related forms to prevent browsers from storing sensitive credentials. This affects sign-in, password reset, account security, and onboarding forms across admin, web, and space apps. Modified components: - Auth forms (email, password, unique code, forgot/reset/set password) - Account security pages - Instance setup and profile onboarding - Shared UI components (auth-input, password-input) * [WEB-5917] fix: generate clean plain text from HTML email template makeplane#8535 * [WEB-5878] chore: add validation for project name/identifier for special characters (makeplane#8529) * chore: update ProjectSerializer to raise validation for special characters in name and identifier * chore: update external endpoints * fix: external api serializer validation * update serializer to send error code * fix: move the regex expression to Project model * [WEB-6194]migration: added archived_at in IssueView makeplane#8641 * migration: added archived_at in IssueView * fix: lint * fix: IDOR Vulnerabilities in Asset & Attachment Endpoints (makeplane#8644) * fix: idor issues in project assets and issue attachements * fix: comments * fix: Member Information Disclosure via Public Endpoint makeplane#8646 * chore: Add forum link and remove discord link on readme (makeplane#8655) * Update README to remove Discord and add Forum link Removed Discord badge and replaced Releases link with Forum link. * Fix forum link in README.md * fix: Update healthcheck endpoint in Dockerfile to target /spaces/ path (makeplane#8674) * Change Dependabot update interval from weekly to daily * [WIKI-887] fix: add scroll in heading layout (makeplane#8596) * fix: add scroll in heading layout * chore: remove visible scroll bar * fix :format * chore: fix outline scroll * chore: fix format * chore: fix translation --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * fix: merge lists in editor (makeplane#8639) * chore: replace prettier with oxfmt (makeplane#8676) * fix: replace eslint with oxlint (makeplane#8677) * fix: replace eslint with oxlint * chore: adding max warning * fix: formatting * chore(deps): minimatch and rollup package vulnerabilities (makeplane#8675) * fix: package updates * fix: package upgrades * fix: minimatch package vulnerabilities * fix: ajv package vulnerabilities * fix: lint * fix: format * [SILO-1028] feat: Project Summary external API (makeplane#8661) * add project summary endpoint * update response structure * [WIKI-852] chore: update page version save logic (makeplane#8440) * chore: updated the logic for page version task * chore: updated the html variable * chore: handled the exception * chore: changed the function name * chore: added a custom variable * [WEB-5225] feat: enhance authentication logging with detailed error and info message (makeplane#7998) * feat: enhance authentication logging with detailed error and info messages - Added logging for various authentication events in the Adapter and its subclasses, including email validation, user existence checks, and password strength validation. - Implemented error handling for GitHub OAuth email retrieval, ensuring proper logging of unexpected responses and missing primary emails. - Updated logging configuration in local and production settings to include a dedicated logger for authentication events. * chore: address copilot comments * chore: addressed some additional comments * chore: update log * fix: lint * [WEB-6420] chore: migrate community references from Discord to Forum (makeplane#8657) * chore: replace Discord references with Forum links * chore: migrate help and community CTAs from Discord to Forum * refactor: replace Discord icons with lucide MessageSquare * chore: rename Discord labels and keys to Forum * chore: remove obsolete Discord icon component * chore: update Discord references to Forum in templates * chore: code refactoring * fix: dependabot and codeql CI * fix: disable react-in-jsx-scope rule in oxlint config (makeplane#8682) After makeplane#8677 replaced ESLint with OxLint, the react-in-jsx-scope rule was not disabled. This causes all commits touching JSX files to fail the pre-commit hook (oxlint --deny-warnings). React 17+ uses automatic JSX runtime so explicit React imports are not required. Fixes makeplane#8681 * chore: space folders (makeplane#8707) * chore: change the space folders structure * fix: format * chore(deps): django version upgrade * [GIT-40]fix: apply sub-issue display filter when adding work items makeplane#8534 * [WEB-5606] fix: work item preview word break makeplane#8537 * [WIKI-892] fix: description input component re-render makeplane#8600 * [WIKI-785] refactor: editor markdown handler makeplane#8546 * [WEB-5911] fix: error outline button text color makeplane#8531 * [SECUR-116] fix: ssrf webhook url for ip address makeplane#8716 * [WEB-6420] chore: self-host social icons in project invitation email (makeplane#8718) * chore: add self-hosted social icon assets for email templates * chore: pass current_site to project invitation email context * chore: replace mailinblue CDN icons with self-hosted static assets * feat: Complete Agent and Worktrees modules - Add Agent CRUD API and frontend - Add Worktrees page with CRUD - Add extended routes for /agents and /worktrees - Add custom sidebar navigation --------- Signed-off-by: majiayu000 <1835304752@qq.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: pratapalakshmi <137189067+pratapalakshmi@users.noreply.github.com> Co-authored-by: b-saikrishnakanth <130811169+b-saikrishnakanth@users.noreply.github.com> Co-authored-by: Nikhil <118773738+pablohashescobar@users.noreply.github.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com> Co-authored-by: Vipin Chaudhary <VipinChaudhary1809@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> Co-authored-by: Dheeraj Kumar Ketireddy <dheeraj.ketireddy@plane.so> Co-authored-by: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Co-authored-by: Aaron <lifeiscontent@users.noreply.github.com> Co-authored-by: M. Palanikannan <73993394+Palanikannan1437@users.noreply.github.com> Co-authored-by: pushya22 <130810100+pushya22@users.noreply.github.com> Co-authored-by: Pushya Mitra Thiruvooru <pushya@Pushyas-MacBook-Pro.local> Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com> Co-authored-by: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Co-authored-by: gakshita <akshitagoyal1516@gmail.com> Co-authored-by: Palanikannan M <akashmalinimurugu@gmail.com> Co-authored-by: Prateek Shourya <prateekshourya29@gmail.com> Co-authored-by: b-saikrishnakanth <bsaikrishnakanth97@gmail.com> Co-authored-by: Henit Chobisa <chobisa.henit@gmail.com> Co-authored-by: Sangeetha <sangeethailango21@gmail.com> Co-authored-by: Anmol Singh Bhatia <anmolsinghbhatia@plane.so> Co-authored-by: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com> Co-authored-by: Shaikh Naasir <yoursdeveloper@protonmail.com> Co-authored-by: lif <1835304752@qq.com> Co-authored-by: NarayanBavisetti <narayan3119@gmail.com> Co-authored-by: vamsikrishnamathala <matalav55@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> Co-authored-by: yy <yhymmt37@gmail.com> Co-authored-by: punto <119956578+AshrithSathu@users.noreply.github.com> Co-authored-by: Ship it <161483884+vcscroll@users.noreply.github.com> Co-authored-by: Akshat Jain <akshatjain9782@gmail.com> Co-authored-by: stelmsk <151884118+stelmsk@users.noreply.github.com> Co-authored-by: Cornelius <70640137+conny3496@users.noreply.github.com> Co-authored-by: Vihar Kurama <vihar.kurama@gmail.com> Co-authored-by: Saurabh Kumar <70131915+Saurabhkmr98@users.noreply.github.com> Co-authored-by: darkingtail <51188676+darkingtail@users.noreply.github.com> Co-authored-by: Claude Code <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR update styling and structure across various components.
Type of Change
Summary by CodeRabbit
Style
UI
✏️ Tip: You can customize this high-level summary in your review settings.