-
Notifications
You must be signed in to change notification settings - Fork 4.7k
regression: red and green color backgrounds #8456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -67,7 +67,7 @@ export const AuthEmailForm = observer(function AuthEmailForm(props: TAuthEmailFo | |||||
| value={email} | ||||||
| onChange={(e) => setEmail(e.target.value)} | ||||||
| placeholder={t("auth.common.email.placeholder")} | ||||||
| className={`disable-autofill-style h-10 w-full placeholder:text-placeholder autofill:bg-red-500 border-0 focus:bg-none active:bg-transparent`} | ||||||
| className={`disable-autofill-style h-10 w-full placeholder:text-placeholder autofill:bg-danger-primary border-0 focus:bg-none active:bg-transparent`} | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistency with the space version of this component. This file uses 🔎 Suggested fix to align with subtle variant pattern- className={`disable-autofill-style h-10 w-full placeholder:text-placeholder autofill:bg-danger-primary border-0 focus:bg-none active:bg-transparent`}
+ className={`disable-autofill-style h-10 w-full placeholder:text-placeholder autofill:bg-danger-subtle border-0 focus:bg-none active:bg-transparent`}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| autoComplete="on" | ||||||
| autoFocus | ||||||
| ref={inputRef} | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import React, { useEffect, useRef } from "react"; | ||
| import { useEffect, useRef } from "react"; | ||
| import { observer } from "mobx-react"; | ||
| import { useForm } from "react-hook-form"; | ||
| import type { EditorRefApi } from "@plane/editor"; | ||
|
|
@@ -111,40 +111,26 @@ export const CommentCardEditForm = observer(function CommentCardEditForm(props: | |
| onClick={handleSubmit(onEnter)} | ||
| disabled={isDisabled} | ||
| className={cn( | ||
| "group rounded-lg border size-7 flex items-center justify-center shadow-md duration-300", | ||
| isDisabled | ||
| ? "cursor-not-allowed border-success-strong/50 bg-success-primary" | ||
| : "border-success-strong bg-success-primary hover:bg-green-500" | ||
| "group rounded-lg border border-success-subtle size-7 grid place-items-center shadow-raised-100 bg-success-subtle duration-300", | ||
| isDisabled ? "" : "hover:bg-success-subtle-1" | ||
| )} | ||
| > | ||
| <CheckIcon | ||
| className={cn( | ||
| "size-4 duration-300", | ||
| isDisabled ? "text-success-primary/50" : "text-success-primary group-hover:text-on-color" | ||
| )} | ||
| /> | ||
| <CheckIcon className="size-4 text-success-primary" /> | ||
| </button> | ||
| )} | ||
| <button | ||
| type="button" | ||
| disabled={isSubmitting} | ||
| className={cn( | ||
| "group rounded-lg border size-7 flex items-center justify-center shadow-md duration-300", | ||
| isSubmitting | ||
| ? "cursor-not-allowed border-danger-strong/50 bg-danger-primary" | ||
| : "border-danger-strong bg-danger-primary hover:bg-red-500" | ||
| "group rounded-lg border border-danger-subtle size-7 grid place-items-center shadow-raised-100 bg-danger-subtle duration-300", | ||
| isSubmitting ? "" : "hover:bg-danger-subtle-hover" | ||
| )} | ||
| onClick={() => { | ||
| setIsEditing(false); | ||
| editorRef.current?.setEditorValue(comment.comment_html ?? "<p></p>"); | ||
| }} | ||
| > | ||
| <CloseIcon | ||
| className={cn( | ||
| "size-5 duration-300", | ||
| isSubmitting ? "text-danger-primary/50" : "text-danger-primary group-hover:text-on-color" | ||
| )} | ||
| /> | ||
| <CloseIcon className="size-4 text-danger-primary" /> | ||
| </button> | ||
|
Comment on lines
121
to
134
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, read the actual file to confirm the code and line numbers
cat -n apps/web/core/components/comments/card/edit-form.tsx | sed -n '100,140p'Repository: makeplane/plane Length of output: 1645 🏁 Script executed: # Search for the submit button code mentioned to verify the line numbers and exact tokens used
rg -A 15 -B 5 "type=\"button\"" apps/web/core/components/comments/card/edit-form.tsxRepository: makeplane/plane Length of output: 1215 🏁 Script executed: # Search for Tailwind config or theme files
fd -t f -e ts -e tsx -e js "tailwind|theme|config" packages/ | head -20Repository: makeplane/plane Length of output: 917 🏁 Script executed: # Search for color token definitions - look for subtle variants
rg -n "subtle.*1|subtle.*hover" --type=ts --type=tsx packages/tailwind-config/ 2>/dev/null | head -30Repository: makeplane/plane Length of output: 41 🏁 Script executed: # Search for usages of both tokens to see if they're used elsewhere
rg "bg-success-subtle-1|bg-danger-subtle-hover" apps/web/Repository: makeplane/plane Length of output: 519 🏁 Script executed: # Search for tailwind config files that define these tokens
find packages/tailwind-config -type f \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" \) | head -20Repository: makeplane/plane Length of output: 101 🏁 Script executed: # Look for the color token definitions
rg -n "success.*subtle|danger.*subtle" packages/tailwind-config/ --type=ts --type=tsx -C 2 | head -50Repository: makeplane/plane Length of output: 86 🏁 Script executed: # Check if there's a theme file or color definitions
cat -n packages/tailwind-config/theme/colors.ts 2>/dev/null | head -100Repository: makeplane/plane Length of output: 41 🏁 Script executed: # List files in tailwind-config directory
ls -la packages/tailwind-config/Repository: makeplane/plane Length of output: 628 🏁 Script executed: # Search for color definitions more broadly
rg -n "subtle-1|subtle-hover" packages/tailwind-config/ -C 2Repository: makeplane/plane Length of output: 7936 🏁 Script executed: # Search for where these color tokens are defined or mapped
rg -n "success-subtle|danger-subtle" packages/ --type=ts -C 2 | head -80Repository: makeplane/plane Length of output: 6513 🏁 Script executed: # Look at theme configuration files
find packages/ -name "*.ts" -o -name "*.js" | xargs grep -l "success-subtle\|danger-subtle" | head -10Repository: makeplane/plane Length of output: 159 Align hover state token naming patterns for consistency. The submit and cancel buttons use inconsistent hover state naming conventions:
Both tokens exist in the design system, but success uses a numeric suffix ( 🤖 Prompt for AI Agents |
||
| </div> | ||
| </form> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -270,7 +270,7 @@ export const InboxIssueActionsHeader = observer(function InboxIssueActionsHeader | |
| /> | ||
| </> | ||
|
|
||
| <Row className="hidden relative lg:flex h-full w-full items-center justify-between gap-2 bg-surface-1 z-[15] border-b border-subtle"> | ||
| <Row className="hidden relative lg:flex h-full w-full items-center justify-between gap-2 bg-surface-1 z-15 border-b border-subtle"> | ||
| <div className="flex items-center gap-4"> | ||
| {isNotificationEmbed && ( | ||
| <button onClick={embedRemoveCurrentNotification}> | ||
|
|
@@ -310,11 +310,11 @@ export const InboxIssueActionsHeader = observer(function InboxIssueActionsHeader | |
|
|
||
| <div className="flex flex-wrap items-center gap-2"> | ||
| {canMarkAsAccepted && ( | ||
| <div className="flex-shrink-0"> | ||
| <div className="shrink-0"> | ||
| <Button | ||
| variant="secondary" | ||
| prependIcon={<CircleCheck className="w-3 h-3" />} | ||
| className="text-success-primary border border-success-strong bg-success-primary focus:bg-success-primary focus:text-success-primary hover:bg-success-primary" | ||
| className="text-on-color border border-success-strong bg-success-primary focus:bg-success-primary focus:text-success-primary hover:bg-success-primary" | ||
|
||
| onClick={() => | ||
| handleActionWithPermission( | ||
| isProjectAdmin, | ||
|
|
@@ -329,11 +329,11 @@ export const InboxIssueActionsHeader = observer(function InboxIssueActionsHeader | |
| )} | ||
|
|
||
| {canMarkAsDeclined && ( | ||
| <div className="flex-shrink-0"> | ||
| <div className="shrink-0"> | ||
| <Button | ||
| variant="secondary" | ||
| prependIcon={<CircleX className="w-3 h-3" />} | ||
| className="text-danger-primary border border-danger-strong bg-danger-primary focus:bg-danger-primary focus:text-danger-primary hover:bg-danger-primary-hover" | ||
| className="text-on-color border border-danger-strong bg-danger-primary focus:bg-danger-primary focus:text-danger-primary hover:bg-danger-primary-hover" | ||
|
aaryan610 marked this conversation as resolved.
|
||
| onClick={() => | ||
| handleActionWithPermission( | ||
| isProjectAdmin, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.