Skip to content

fix: Collapsible content never renders in controlled mode #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofried-acutis wants to merge 2 commits into
base: preview
Choose a base branch
from
+10 −20
Open

fix: Collapsible content never renders in controlled mode #8777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe1301a
fix: Collapsible content never renders in controlled mode
ofried-acutis Mar 19, 2026
6dcfe54
fix: add aria-expanded and fix propel collapsible state init
ofried-acutis Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/propel/src/collapsible/collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const useCollapsible = () => {

// Components
function Root({ children, className, isOpen: controlledIsOpen, onToggle, defaultOpen }: RootProps) {
const [localIsOpen, setLocalIsOpen] = useState<boolean>(controlledIsOpen || defaultOpen || false);
const [localIsOpen, setLocalIsOpen] = useState<boolean>(controlledIsOpen !== undefined ? controlledIsOpen : !!defaultOpen);

useEffect(() => {
if (controlledIsOpen !== undefined) {
Expand Down
28 changes: 9 additions & 19 deletions packages/ui/src/collapsible/collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import { Disclosure, Transition } from "@headlessui/react";
import React, { useState, useEffect, useCallback } from "react";

export type TCollapsibleProps = {
Expand All @@ -21,7 +20,7 @@ export type TCollapsibleProps = {
export function Collapsible(props: TCollapsibleProps) {
const { title, children, buttonRef, className, buttonClassName, isOpen, onToggle, defaultOpen } = props;
// state
const [localIsOpen, setLocalIsOpen] = useState<boolean>(isOpen || defaultOpen ? true : false);
const [localIsOpen, setLocalIsOpen] = useState<boolean>(isOpen !== undefined ? isOpen : !!defaultOpen);

useEffect(() => {
if (isOpen !== undefined) {
Expand All @@ -39,24 +38,15 @@ export function Collapsible(props: TCollapsibleProps) {
}, [isOpen, onToggle]);

return (
<Disclosure as="div" className={className}>
<Disclosure.Button ref={buttonRef} className={buttonClassName} onClick={handleOnClick}>
<div className={className}>
<button ref={buttonRef} type="button" className={buttonClassName} onClick={handleOnClick} aria-expanded={localIsOpen}>
{title}
</Disclosure.Button>
<Transition
show={localIsOpen}
enter="transition-all duration-300 ease-in-out"
enterFrom="grid-rows-[0fr] opacity-0"
enterTo="grid-rows-[1fr] opacity-100"
leave="transition-all duration-300 ease-in-out"
leaveFrom="grid-rows-[1fr] opacity-100"
leaveTo="grid-rows-[0fr] opacity-0"
className="grid overflow-hidden"
>
<Disclosure.Panel static className="min-h-0">
</button>
{localIsOpen && (
<div className="min-h-0">
{children}
</Disclosure.Panel>
</Transition>
</Disclosure>
</div>
)}
</div>
);
}