fix: pnpm path for Docker builds#9079
Conversation
Add $PNPM_HOME/bin to PATH so corepack-installed pnpm binaries are resolvable during Docker builds.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds $PNPM_HOME/bin to the PATH in the four community Dockerfiles so that corepack-installed pnpm binaries are resolvable during Docker builds, mirroring the enterprise fix in makeplane/plane-ee#7150.
Changes:
- Update
PATHin admin, live, space, and web Dockerfiles to include$PNPM_HOME/bin.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/admin/Dockerfile.admin | Append $PNPM_HOME/bin to PATH for corepack pnpm resolution. |
| apps/live/Dockerfile.live | Append $PNPM_HOME/bin to PATH for corepack pnpm resolution. |
| apps/space/Dockerfile.space | Append $PNPM_HOME/bin to PATH for corepack pnpm resolution. |
| apps/web/Dockerfile.web | Append $PNPM_HOME/bin to PATH for corepack pnpm resolution. |
Summary
$PNPM_HOME/bintoPATHin community Dockerfiles so corepack-installed pnpm binaries are resolvable during Docker builds.Files updated:
apps/admin/Dockerfile.adminapps/live/Dockerfile.liveapps/space/Dockerfile.spaceapps/web/Dockerfile.webChange:
ENV PATH="$PNPM_HOME:$PATH"→ENV PATH="$PNPM_HOME:$PNPM_HOME/bin:$PATH"Test plan