Minor doc update. Props are height and width.#73
Open
patrice4github wants to merge 1 commit intomalsapp:masterfrom
patrice4github:width_and_height_doc
Open
Minor doc update. Props are height and width.#73patrice4github wants to merge 1 commit intomalsapp:masterfrom patrice4github:width_and_height_doc
patrice4github wants to merge 1 commit intomalsapp:masterfrom
patrice4github:width_and_height_doc
Conversation
…d width, not maxHeight and maxWidth:
state = {
maxHeight: this.props.height || 600,
maxWidth: this.props.width || 600,
Using height instead maxHeight worked correctly on my app. Setting
maxHeight had no effect.
patrice4github
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor doc update. From the code we can read that it's height and width, not maxHeight and maxWidth:
Using height instead maxHeight worked correctly on my app. Setting
maxHeight had no effect.