feat(types): Make explicit widget_manager interface - #670
Merged
Conversation
🦋 Changeset detectedLatest commit: 43117b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manzt
force-pushed
the
widget-manager-types
branch
from
August 29, 2024 13:19
3bb31a7 to
0720abe
Compare
Merged
manzt
added a commit
that referenced
this pull request
Mar 1, 2025
…pendencies` In #670, `@anywidget/types` was inadvertently moved to `devDependencies` for the `anywidget` npm package, causing it to no longer be installed for users of `anywidget` and breaking imports from `anywidget/types`. Since splitting our types into a separate package, we generally encourage using `@anywidget/types` directly, allowing the [AFM](https://anywidget.dev/en/afm) spec to be versioned independently from the Python bindings/runtime. However, we can at least continue to ship to avoid breaking builds.
manzt
added a commit
that referenced
this pull request
Mar 1, 2025
…pendencies` In #670, `@anywidget/types` was inadvertently moved to `devDependencies` for the `anywidget` npm package, causing it to no longer be installed for users of `anywidget` and breaking imports from `anywidget/types`. Since splitting our types into a separate package, we generally encourage using `@anywidget/types` directly, allowing the [AFM](https://anywidget.dev/en/afm) spec to be versioned independently from the Python bindings/runtime. However, we can at least continue to ship to avoid breaking builds.
manzt
added a commit
that referenced
this pull request
Mar 1, 2025
…pendencies` (#812) In #670, `@anywidget/types` was inadvertently moved to `devDependencies` for the `anywidget` npm package, causing it to no longer be installed for users of `anywidget` and breaking imports from `anywidget/types`. Since splitting our types into a separate package, we generally encourage using `@anywidget/types` directly, allowing the [AFM](https://anywidget.dev/en/afm) spec to be versioned independently from the Python bindings/runtime. However, we can at least continue to ship to avoid breaking builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes explicit WidgetManager interface
Drops
@jupyter-widgets/baseas a dependency and instead makes an explicitinterface for
AnyModel.widget_manager. Right now we only supportwidget_manager.get_model, so having the other methods on the interface wasmisleading (leading to issues around
.create_viewnot being supported).