Conversation
|
Thanks @ewanharris, will do a new release with this soon |
|
@springmeyer, I hit an issue with 17.0.0 where it was missing headers and causing the build to fail. I think 17.0.1 is potentially being released today with the fix (nodejs/node/pull/40535). Once that's released I'll add |
Sounds good. Although the way the code is written internally in node-pre-gyp, it should not need 17.0.1 explicitly declared in order to function properly. It only needs at least one major version declared. I realize this is not obvious (you'd think the explicit nature of the crosswalk means that the minor and patch versions are needed, but that was avoided after f091f23#diff-731dda4952e8957a5d9387cd5ed656a10a7a6fd6e22b1ab3ef12502a9917e03d) |
|
Oh that's neat, I didn't realise that! I guess this is good to merge then! |
feat: add node 17 support
Updates abi_crosswalk to include newer versions of node, including 17