Repository navigation
feat(keymap): add option to disable command mode on Escape - #9907
ameenalkhaldi wants to merge 1 commit into
Conversation
Add `enter_command_mode_on_escape` config option to allow users to disable the Escape key from entering command mode in the cell editor. This is useful for users whose muscle memory expects Escape to clear hint popups rather than navigate to command mode. Closes marimo-team#7426
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
This pull request has been automatically marked as stale because it has not had activity in 30 days. It will be closed in 14 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. Thank you for your contribution! |
|
This pull request has been automatically closed due to inactivity. Feel free to reopen it if you'd like to continue working on it. |
This pull request was authored by a coding agent.
Summary
Adds a new
enter_command_mode_on_escapeconfiguration option to the keymap settings, allowing users to disable the Escape key from entering command mode in the cell editor.This addresses the issue where users' muscle memory expects Escape to clear hint popups (like autocomplete or signature help) rather than navigate to command mode.
Changes
enter_command_mode_on_escape: NotRequired[bool]to backendKeymapConfiginmarimo/_config/config.pyconfig-schema.tsnavigation.tsto respect the config optionUsage
Users can set this in their marimo config (e.g.,
~/.marimo.toml):Default is
true(existing behavior preserved).Test plan
pytest tests/_config/)make fe-typecheck)make py-check)make fe-codegen)Closes #7426