Fix breaks#1507
Merged
UziTech merged 2 commits intomarkedjs:masterfrom Jun 29, 2019
UziTech:fix-breaks
Merged
Conversation
Member
Author
|
This fixes the breaks but it adds back the redos in quadradic_br.js when |
Member
Author
|
This should be released soon since this probably affects a lot of marked users |
styfle
approved these changes
Jun 28, 2019
Member
styfle
left a comment
There was a problem hiding this comment.
I don't know what is worse, broken breaks or redos 🤷♂
Contributor
|
Let's get this merged. I think fixing a behavior regression is more important than a performance regression. |
davisjam
approved these changes
Jun 29, 2019
|
Thank you! |
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 0.6.2
Markdown flavor: GitHub Flavored Markdown with breaks
Description
the
breaks: trueoption broke in v0.6.2 because of #1460This reverts the change only when the
breaksoption is set to true.breaksoption (Regression) #1505Contributor
Committer
In most cases, this should be a different person than the contributor.