Merged
Conversation
Only code fences made from backticks cannot have other backticks in the same line. Fences with tildes can have both tildes and backticks. This allows the tilde case to work correctly. Also test for detection of these fences as they break or do not break paragraphs.
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
4 tasks
Contributor
Author
|
Cool. Does anything else need to happen to merge this? |
calculuschild
added a commit
to calculuschild/marked
that referenced
this pull request
Feb 11, 2020
Fences after tables fixed in line with PR markedjs#1600.
|
Deployment failed with the following error: |
This was referenced Mar 21, 2020
This was referenced Mar 30, 2020
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 8.0
Markdown flavor: CommonMark & GitHub Flavored Markdown
Description
Also adds tests for detection of these fences if they should or not break paragraphs.
Implementing code as discussed in #1598 (comment)
Contributor
Committer
In most cases, this should be a different person than the contributor.