fix: trim trailing whitespace from lheading text#3920
fix: trim trailing whitespace from lheading text#3920UziTech merged 1 commit intomarkedjs:masterfrom
Conversation
ATX headings (## heading) already call cap[2].trim() before storing the text value. Setext/lheading headings used cap[1] directly without trimming, so trailing spaces on the heading line were included in the token text field. Applied the same .trim() to bring lheading into parity with ATX heading behaviour, and added a unit test to prevent regression.
|
@VeerShah41 is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the parsing behavior for Setext/lheading headings by ensuring that any trailing whitespace in the heading text is removed. This change brings lheading parsing into parity with ATX heading parsing, where trimming already occurs, leading to more consistent and predictable output when processing Markdown. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements trimming of whitespace from lheading text, making its behavior consistent with ATX headings. The change is straightforward and accompanied by a new unit test. I've suggested a small improvement to the test to make it more comprehensive by covering additional cases.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
## [17.0.5](v17.0.4...v17.0.5) (2026-03-20) ### Bug Fixes * Fix catastrophic backtracking (ReDoS) in link/reflink label regex ([#3918](#3918)) ([4625980](4625980)) * prevent quadratic complexity in emStrongLDelim regex ([#3906](#3906)) ([c732dd2](c732dd2)) * prevent single-tilde strikethrough false positives ([#3910](#3910)) ([5e03369](5e03369)) * re-assign tokenizer.lexer and renderer.parser at start of each parse call ([#3907](#3907)) ([f3a3ec0](f3a3ec0)) * trim trailing whitespace from lheading text ([#3920](#3920)) ([3ea7e88](3ea7e88))
3 participants
ATX headings (## heading) already call cap[2].trim() before storing the text value. Setext/lheading headings used cap[1] directly without trimming, so trailing spaces on the heading line were included in the token text field.
Applied the same .trim() to bring lheading into parity with ATX heading behaviour, and added a unit test to prevent regression.
Marked version:
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.