URL's passed to closures should be file URL's #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the URL's for unzipped files don't start with "file://" they can cause problems if they are passed into other parts of iOS (eg share sheets). Changing the URL constructor to generate file type URL's also correctly handles paths with spaces. This eliminates the manual handling of these that's currently done.
696GrocuttT
force-pushed
the
master
branch
4 times, most recently
from
2cf1686 to
0add50d
Compare
This reverts commit c21bc22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the URL's for unzipped files don't start with "file://" they can cause problems if
they are passed into other parts of iOS (eg share sheets).
Changing the URL constructor to generate file type URL's also correctly handles
paths with spaces. This eliminates the manual handling of these that's currently done.